Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 257963003: Remove scroll_offset argument from MovePluginWindow (Closed)

Created:
6 years, 8 months ago by jbauman
Modified:
6 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, creis+watch_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nasko+codewatch_chromium.org, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org
Visibility:
Public.

Description

Remove scroll_offset argument from MovePluginWindow The math with it just cancels out, so it's not necessary. BUG= TEST=open http://www.w3schools.com/html/tryit.asp?filename=tryhtml_youtubeobject with NPAPI flash and scroll it Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266776

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -17 lines) Patch
M content/browser/frame_host/render_widget_host_view_child_frame.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +2 lines, -4 lines 1 comment Download
M content/browser/renderer_host/render_widget_host_view_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_mac.mm View 1 chunk +0 lines, -1 line 0 comments Download
M content/port/browser/render_widget_host_view_port.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/test_render_view_host.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
jbauman
This is part of my ongoing effort to simplify/remove UpdateRect. https://codereview.chromium.org/257963003/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc File content/browser/renderer_host/render_widget_host_view_aura.cc (right): https://codereview.chromium.org/257963003/diff/1/content/browser/renderer_host/render_widget_host_view_aura.cc#newcode783 ...
6 years, 8 months ago (2014-04-25 23:42:35 UTC) #1
jam
lgtm
6 years, 7 months ago (2014-04-28 20:48:32 UTC) #2
jam
btw have you verified that scrolling pages with windowed NPAPI plugins work fine?
6 years, 7 months ago (2014-04-28 20:48:56 UTC) #3
jbauman
On 2014/04/28 20:48:56, jam wrote: > btw have you verified that scrolling pages with windowed ...
6 years, 7 months ago (2014-04-28 21:34:57 UTC) #4
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 7 months ago (2014-04-28 21:44:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/257963003/1
6 years, 7 months ago (2014-04-28 21:45:17 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 22:36:36 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 7 months ago (2014-04-28 22:36:37 UTC) #8
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 7 months ago (2014-04-28 22:59:03 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/257963003/1
6 years, 7 months ago (2014-04-28 22:59:59 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 07:49:26 UTC) #11
Message was sent while issue was closed.
Change committed as 266776

Powered by Google App Engine
This is Rietveld 408576698