Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Side by Side Diff: chrome/browser/ui/toolbar/media_router_action.cc

Issue 2579613002: [Media Router Action] Hide action back in the overflow menu after popping it out (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/toolbar/media_router_action.h" 5 #include "chrome/browser/ui/toolbar/media_router_action.h"
6 6
7 #include "base/metrics/user_metrics.h" 7 #include "base/metrics/user_metrics.h"
8 #include "base/strings/utf_string_conversions.h" 8 #include "base/strings/utf_string_conversions.h"
9 #include "chrome/browser/media/router/issue.h" 9 #include "chrome/browser/media/router/issue.h"
10 #include "chrome/browser/media/router/media_route.h" 10 #include "chrome/browser/media/router/media_route.h"
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 } 131 }
132 132
133 gfx::NativeView MediaRouterAction::GetPopupNativeView() { 133 gfx::NativeView MediaRouterAction::GetPopupNativeView() {
134 return nullptr; 134 return nullptr;
135 } 135 }
136 136
137 ui::MenuModel* MediaRouterAction::GetContextMenu() { 137 ui::MenuModel* MediaRouterAction::GetContextMenu() {
138 return contextual_menu_.menu_model(); 138 return contextual_menu_.menu_model();
139 } 139 }
140 140
141 void MediaRouterAction::OnContextMenuClosed() {
142 if (toolbar_actions_bar_ &&
143 toolbar_actions_bar_->popped_out_action() == this &&
144 !GetMediaRouterDialogController()->IsShowingMediaRouterDialog()) {
145 toolbar_actions_bar_->UndoPopOut();
146 }
147 }
148
141 bool MediaRouterAction::ExecuteAction(bool by_user) { 149 bool MediaRouterAction::ExecuteAction(bool by_user) {
142 base::RecordAction(base::UserMetricsAction("MediaRouter_Icon_Click")); 150 base::RecordAction(base::UserMetricsAction("MediaRouter_Icon_Click"));
143 151
144 if (GetMediaRouterDialogController()->IsShowingMediaRouterDialog()) { 152 if (GetMediaRouterDialogController()->IsShowingMediaRouterDialog()) {
145 GetMediaRouterDialogController()->HideMediaRouterDialog(); 153 GetMediaRouterDialogController()->HideMediaRouterDialog();
146 return false; 154 return false;
147 } 155 }
148 156
149 GetMediaRouterDialogController()->ShowMediaRouterDialog(); 157 GetMediaRouterDialogController()->ShowMediaRouterDialog();
150 if (GetPlatformDelegate()) { 158 if (GetPlatformDelegate()) {
(...skipping 124 matching lines...) Expand 10 before | Expand all | Expand 10 after
275 if (severity == media_router::IssueInfo::Severity::FATAL) 283 if (severity == media_router::IssueInfo::Severity::FATAL)
276 return gfx::VectorIconId::MEDIA_ROUTER_ERROR; 284 return gfx::VectorIconId::MEDIA_ROUTER_ERROR;
277 if (severity == media_router::IssueInfo::Severity::WARNING) 285 if (severity == media_router::IssueInfo::Severity::WARNING)
278 return gfx::VectorIconId::MEDIA_ROUTER_WARNING; 286 return gfx::VectorIconId::MEDIA_ROUTER_WARNING;
279 // Fall through for Severity::NOTIFICATION. 287 // Fall through for Severity::NOTIFICATION.
280 } 288 }
281 289
282 return has_local_display_route_ ? gfx::VectorIconId::MEDIA_ROUTER_ACTIVE 290 return has_local_display_route_ ? gfx::VectorIconId::MEDIA_ROUTER_ACTIVE
283 : gfx::VectorIconId::MEDIA_ROUTER_IDLE; 291 : gfx::VectorIconId::MEDIA_ROUTER_IDLE;
284 } 292 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698