Issue 2579523003: add --assert-message flag back

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2579523003: add --assert-message flag back (Closed)

Created:
4 years ago by Harry Terkelsen

Modified:
4 years ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

add --assert-message flag back Committed: https://github.com/dart-lang/sdk/commit/c05c73f0778b8a491f2bd678b2179874c8afa5eb

Patch Set 1 #

Patch Set 2 : oops #

Patch Set 3 : git cl land #

Created: 4 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -0 lines)			Patch
M	pkg/compiler/lib/src/commandline_options.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/dart2js.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/options.dart	View	6 chunks	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Harry Terkelsen

Committed patchset #3 (id:40001) manually as c05c73f0778b8a491f2bd678b2179874c8afa5eb (presubmit successful).

4 years ago (2016-12-15 01:25:00 UTC) #4

Siggi Cherem (dart-lang)

4 years ago (2016-12-15 04:44:40 UTC) #5

Message was sent while issue was closed.

lgtm, any reason to add it back? Is it mainly so we don't fail when people
provide it?

If so - we could probably still remove it from options.dart and only keep it in
the parsing of flags

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages