Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h

Issue 2579513005: Expose FontFaceSetLoadEvent and add a constructor for it (Closed)
Patch Set: Make fontfaces FrozenArray [SameObject] Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h b/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h
index d9cd41637c832b5da4f7e9f4e01f101279a1370d..d605d2b0c6f88846eebe786372d540417e7d6275 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h
+++ b/third_party/WebKit/Source/bindings/core/v8/V8PrivateProperty.h
@@ -21,19 +21,20 @@ class ScriptState;
class ScriptWrappable;
// Apply |X| for each pair of (InterfaceName, PrivateKeyName).
-#define V8_PRIVATE_PROPERTY_FOR_EACH(X) \
- X(CustomEvent, Detail) \
- X(DOMException, Error) \
- X(ErrorEvent, Error) \
- X(IDBObserver, Callback) \
- X(IntersectionObserver, Callback) \
- X(MessageEvent, CachedData) \
- X(MutationObserver, Callback) \
- X(PerformanceObserver, Callback) \
- X(SameObject, NotificationActions) \
- X(SameObject, NotificationData) \
- X(SameObject, NotificationVibrate) \
- X(V8NodeFilterCondition, Filter) \
+#define V8_PRIVATE_PROPERTY_FOR_EACH(X) \
+ X(CustomEvent, Detail) \
+ X(DOMException, Error) \
+ X(ErrorEvent, Error) \
+ X(IDBObserver, Callback) \
+ X(IntersectionObserver, Callback) \
+ X(MessageEvent, CachedData) \
+ X(MutationObserver, Callback) \
+ X(PerformanceObserver, Callback) \
+ X(SameObject, FontFaceSetLoadEventFontfaces) \
foolip 2016/12/16 14:46:36 I didn't know we had to do this for SaveSameObject
lunalu1 2016/12/16 15:44:56 If we don't do that, it simply won't compile.
foolip 2016/12/16 16:13:07 Right, I'm just wondering if there's any cost to i
+ X(SameObject, NotificationActions) \
+ X(SameObject, NotificationData) \
+ X(SameObject, NotificationVibrate) \
+ X(V8NodeFilterCondition, Filter) \
X(Window, DocumentCachedAccessor)
// The getter's name for a private property.

Powered by Google App Engine
This is Rietveld 408576698