Move surface resize platform code from GpuProcessHostUIShim to RenderWidgetHostView implementations.

Move surface resize platform code from GpuProcessHostUIShim to RenderWidgetHostView implementations.

BUG=303425
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228785

[Ken Russell (switch to Gerrit), 2013-10-02 21:21:02]

+piman

Could you please provide a little more background on the motivation for this
change? Please file a bug and reference it from the CL.

[ostap, 2013-10-02 22:25:13]

On 2013/10/02 21:21:02, Ken Russell wrote:
> +piman
> 
> Could you please provide a little more background on the motivation for this
> change? Please file a bug and reference it from the CL.

We are doing embedder that implements its own RenderVidgetHostView and needs
SurfaceResize message.
Also, it could be seen as simple re-factoring to move platform code out of
GpuProcessHostUIShim which is platform independent otherwise.

[piman, 2013-10-03 00:17:28]

Some simplifications can be done. Overall, I think the refactoring makes sense.

However, we definitely do not encourage making your own RWHV out of tree. Things
will break.
I suggest instead using Aura and Ozone.

https://codereview.chromium.org/25795002/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/render_widget_host_view_gtk.cc (right):

https://codereview.chromium.org/25795002/diff/1/content/browser/renderer_host...
content/browser/renderer_host/render_widget_host_view_gtk.cc:1301:
gdk_xid_table_lookup(surface.handle));
This can probably be simplified now, by getting the GdkWindow directly from the
GtkWidget

https://codereview.chromium.org/25795002/diff/1/content/browser/renderer_host...
File content/browser/renderer_host/render_widget_host_view_win.cc (right):

https://codereview.chromium.org/25795002/diff/1/content/browser/renderer_host...
content/browser/renderer_host/render_widget_host_view_win.cc:2562:
SetWindowPos(surface.handle,
surface.handle is compositor_host_window_

[ostap, 2013-10-03 03:00:08]

Updated by review comments.

[Jói, 2013-10-03 13:44:07]

LGTM

[piman, 2013-10-03 18:32:08]

lgtm

[Ken Russell (switch to Gerrit), 2013-10-03 18:36:56]

I defer to piman's review. LGTM in case it's needed.

[commit-bot: I haz the power, 2013-10-04 13:08:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/25795002/8001

[commit-bot: I haz the power, 2013-10-04 19:47:46]

Change committed as 227058

[ostap, 2013-10-04 22:19:48]

Patch is updated for reland after revert because windows webkit trybot fails on
CWindow:SetWindowPos conflicting with ::SetWindowPos .

[piman, 2013-10-04 23:48:24]

lgtm

[ostap, 2013-10-08 21:28:34]

On 2013/10/04 23:48:24, piman wrote:
> lgtm

Could you start win_blink_rel and win_blink try bots for this change, please? It
seems the commit queue doesn't run them and I'd like to be sure that it they are
not broken.

Thanks.

[commit-bot: I haz the power, 2013-10-15 20:03:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sl.ostapenko@samsung.com/25795002/39001

[ostap, 2013-10-15 20:04:25]

On 2013/10/08 21:28:34, ostap wrote:
> On 2013/10/04 23:48:24, piman wrote:
> > lgtm
> 
> Could you start win_blink_rel and win_blink try bots for this change, please?
It
> seems the commit queue doesn't run them and I'd like to be sure that it they
are
> not broken.
> 
> Thanks.

Seems blink try bots are trying to apply patch to the blink tree.
Trying to commit it and watch the bots as agreed with enne on #blink.

[commit-bot: I haz the power, 2013-10-15 22:45:18]

Change committed as 228785