Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Unified Diff: src/inspector/v8-debugger.h

Issue 2579403002: [inspector] introduce limit for amount of stored async stacks (Closed)
Patch Set: a Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/inspector/v8-debugger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-debugger.h
diff --git a/src/inspector/v8-debugger.h b/src/inspector/v8-debugger.h
index b1c044a06906f986bed52cfee54e12798f38809e..ab663a3f3027249a61b55a6429c154505bb5f893 100644
--- a/src/inspector/v8-debugger.h
+++ b/src/inspector/v8-debugger.h
@@ -5,6 +5,7 @@
#ifndef V8_INSPECTOR_V8DEBUGGER_H_
#define V8_INSPECTOR_V8DEBUGGER_H_
+#include <deque>
#include <vector>
#include "src/base/macros.h"
@@ -135,6 +136,7 @@ class V8Debugger {
v8::Local<v8::Function>);
v8::MaybeLocal<v8::Value> generatorScopes(v8::Local<v8::Context>,
v8::Local<v8::Value>);
+ void cleanupScheduledOrderIfNeeded();
v8::Isolate* m_isolate;
V8InspectorImpl* m_inspector;
@@ -150,6 +152,8 @@ class V8Debugger {
using AsyncTaskToStackTrace =
protocol::HashMap<void*, std::unique_ptr<V8StackTraceImpl>>;
AsyncTaskToStackTrace m_asyncTaskStacks;
+ std::deque<void*> m_scheduledOrder;
dgozman 2016/12/16 22:36:11 Can we instead have two maps: void* -> task_id, an
kozy 2016/12/16 22:56:15 Done.
+ std::unordered_set<void*> m_scheduledOrderDeleted;
protocol::HashSet<void*> m_recurringTasks;
int m_maxAsyncCallStackDepth;
std::vector<void*> m_currentTasks;
« no previous file with comments | « no previous file | src/inspector/v8-debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698