 Chromium Code Reviews
 Chromium Code Reviews Issue 2579403002:
  [inspector] introduce limit for amount of stored async stacks  (Closed)
    
  
    Issue 2579403002:
  [inspector] introduce limit for amount of stored async stacks  (Closed) 
  | Index: src/inspector/v8-debugger.h | 
| diff --git a/src/inspector/v8-debugger.h b/src/inspector/v8-debugger.h | 
| index b1c044a06906f986bed52cfee54e12798f38809e..ab663a3f3027249a61b55a6429c154505bb5f893 100644 | 
| --- a/src/inspector/v8-debugger.h | 
| +++ b/src/inspector/v8-debugger.h | 
| @@ -5,6 +5,7 @@ | 
| #ifndef V8_INSPECTOR_V8DEBUGGER_H_ | 
| #define V8_INSPECTOR_V8DEBUGGER_H_ | 
| +#include <deque> | 
| #include <vector> | 
| #include "src/base/macros.h" | 
| @@ -135,6 +136,7 @@ class V8Debugger { | 
| v8::Local<v8::Function>); | 
| v8::MaybeLocal<v8::Value> generatorScopes(v8::Local<v8::Context>, | 
| v8::Local<v8::Value>); | 
| + void cleanupScheduledOrderIfNeeded(); | 
| v8::Isolate* m_isolate; | 
| V8InspectorImpl* m_inspector; | 
| @@ -150,6 +152,8 @@ class V8Debugger { | 
| using AsyncTaskToStackTrace = | 
| protocol::HashMap<void*, std::unique_ptr<V8StackTraceImpl>>; | 
| AsyncTaskToStackTrace m_asyncTaskStacks; | 
| + std::deque<void*> m_scheduledOrder; | 
| 
dgozman
2016/12/16 22:36:11
Can we instead have two maps: void* -> task_id, an
 
kozy
2016/12/16 22:56:15
Done.
 | 
| + std::unordered_set<void*> m_scheduledOrderDeleted; | 
| protocol::HashSet<void*> m_recurringTasks; | 
| int m_maxAsyncCallStackDepth; | 
| std::vector<void*> m_currentTasks; |