Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: chrome/browser/android/offline_pages/offline_page_mhtml_archiver_unittest.cc

Issue 2579343002: [Offline Pages] Make new archives have random file names. (Closed)
Patch Set: Remove unnecessary includes Created 3 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_mhtml_archiver_unittest.cc
diff --git a/chrome/browser/android/offline_pages/offline_page_mhtml_archiver_unittest.cc b/chrome/browser/android/offline_pages/offline_page_mhtml_archiver_unittest.cc
index b6539b51edeb506d6413271b05dbf8154b34bf6f..72845cacf0302c3e01bed98f6f80702fa32b6b2c 100644
--- a/chrome/browser/android/offline_pages/offline_page_mhtml_archiver_unittest.cc
+++ b/chrome/browser/android/offline_pages/offline_page_mhtml_archiver_unittest.cc
@@ -233,37 +233,4 @@ TEST_F(OfflinePageMHTMLArchiverTest, SuccessfullyCreateOfflineArchive) {
EXPECT_EQ(kTestFileSize, last_file_size());
}
-TEST_F(OfflinePageMHTMLArchiverTest, GenerateFileName) {
- GURL url_1("http://news.google.com/page1");
- std::string title_1("Google News Page");
- base::FilePath expected_1(FILE_PATH_LITERAL(
- "news.google.com-Google_News_Page-1234.mhtml"));
- base::FilePath actual_1(
- OfflinePageMHTMLArchiver::GenerateFileName(url_1, title_1, 1234LL));
- EXPECT_EQ(expected_1, actual_1);
-
- GURL url_2("https://en.m.wikipedia.org/Sample_page_about_stuff");
- std::string title_2("Some Wiki Page");
- base::FilePath expected_2(FILE_PATH_LITERAL(
- "en.m.wikipedia.org-Some_Wiki_Page-56789.mhtml"));
- base::FilePath actual_2(
- OfflinePageMHTMLArchiver::GenerateFileName(url_2, title_2, 56789LL));
- EXPECT_EQ(expected_2, actual_2);
-
- GURL url_3("https://www.google.com/search");
- std::string title_3 =
- "A really really really really really long title "
- "that is over 80 chars long here^ - TRUNCATE THIS PART";
- std::string expected_title_3_part =
- "A_really_really_really_really_really_long_title_"
- "that_is_over_80_chars_long_here^";
- base::FilePath expected_3(
- FILE_PATH_LITERAL("www.google.com-" +
- expected_title_3_part +
- "-123456789.mhtml"));
- base::FilePath actual_3(
- OfflinePageMHTMLArchiver::GenerateFileName(url_3, title_3, 123456789LL));
- EXPECT_EQ(expected_3, actual_3);
-}
-
} // namespace offline_pages

Powered by Google App Engine
This is Rietveld 408576698