Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2579283002: Elide origins for passwords settings in CSS instead of JS (Closed)

Created:
4 years ago by vabr (Chromium)
Modified:
4 years ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Elide origins for passwords settings in CSS instead of JS Displayed origins of stored passwords are elided to fit the cell they are in. The ellipsis needs to be applied from the left, because the most important security information about the hostname are the top (right-most) parts of the domain [1]. In the past this needed to be done by password_manager.js, because changing the text direction in CSS to allow eliding from left left to issues with screen readers. This CL drops the JS code for computing the elided string, and instead specifies the text direction for the hostname to be RTL. This applies the ellipsis from left, while working as expected with the screen reader, and not interfering with the text direction of the Chrome UI. [1] https://www.chromium.org/Home/chromium-security/enamel#TOC-Eliding-Origin-Names-And-Hostnames BUG=667130 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2567693002 Cr-Commit-Position: refs/heads/master@{#438469} (cherry picked from commit 7f5230e3d8213f33ba0f1014b1e682f75e36028f) Committed: https://chromium.googlesource.com/chromium/src/+/2a7c201888f97779886fc374eeffaafcc385e43c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -57 lines) Patch
M chrome/browser/resources/options/password_manager.js View 3 chunks +0 lines, -56 lines 0 comments Download
M chrome/browser/resources/options/password_manager_list.css View 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/password_manager_list.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
vabr (Chromium)
4 years ago (2016-12-16 10:44:08 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2a7c201888f97779886fc374eeffaafcc385e43c.

Powered by Google App Engine
This is Rietveld 408576698