Chromium Code Reviews
DescriptionElide origins for passwords settings in CSS instead of JS
Displayed origins of stored passwords are elided to fit the cell they are in.
The ellipsis needs to be applied from the left, because the most important
security information about the hostname are the top (right-most) parts of the
domain [1]. In the past this needed to be done by password_manager.js, because
changing the text direction in CSS to allow eliding from left left to issues
with screen readers.
This CL drops the JS code for computing the elided string, and instead specifies
the text direction for the hostname to be RTL. This applies the ellipsis from left,
while working as expected with the screen reader, and not interfering with the
text direction of the Chrome UI.
[1] https://www.chromium.org/Home/chromium-security/enamel#TOC-Eliding-Origin-Names-And-Hostnames
BUG=667130
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2567693002
Cr-Commit-Position: refs/heads/master@{#438469}
(cherry picked from commit 7f5230e3d8213f33ba0f1014b1e682f75e36028f)
Committed: https://chromium.googlesource.com/chromium/src/+/2a7c201888f97779886fc374eeffaafcc385e43c
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|
|||||||||||||||||||||||||||||||||||||