Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 2579253003: Add one more test for configurable imports. (Closed)

Created:
4 years ago by Lasse Reichstein Nielsen
Modified:
4 years ago
Reviewers:
mit, eernst
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -0 lines) Patch
A tests/language/config_import_corelib_general.dart View 1 chunk +10 lines, -0 lines 0 comments Download
A tests/language/config_import_corelib_http.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A tests/language/config_import_corelib_io.dart View 1 chunk +14 lines, -0 lines 0 comments Download
A tests/language/config_import_corelib_test.dart View 1 chunk +53 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Lasse Reichstein Nielsen
4 years ago (2016-12-16 13:09:10 UTC) #2
eernst
lgtm
4 years ago (2016-12-16 13:17:14 UTC) #3
mit
On 2016/12/16 13:09:10, Lasse Reichstein Nielsen wrote: LGTM, thanks Lasse!
4 years ago (2016-12-16 13:17:20 UTC) #4
Lasse Reichstein Nielsen
4 years ago (2016-12-16 13:44:55 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
04c33c841324f4f5fdd57b2dadd1ae76c5f6d46e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698