Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 25792002: Turn off ash and aura by default on linux blink bots. (Closed)

Created:
7 years, 2 months ago by Dirk Pranke
Modified:
7 years, 2 months ago
Reviewers:
iannucci
CC:
chromium-reviews, cmp-cc_chromium.org, kjellander+cc_chromium.org, xusydoc+watch_chromium.org, ilevy-cc_chromium.org, cpu_(ooo_6.6-7.5), Elliot Glaysher
Visibility:
Public.

Description

Turn off ash and aura by default on linux blink bots. We're getting ready to enable Aura and Ash on Linux by default, but the layout tests need to be updated to use the mock theme. Until then, we'll force Aura and Ash off on the bots so that the tests continue to pass. (This is the same as we're currently doing on the Win bots). R=iannucci@chromium.org BUG=125106 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=226850

Patch Set 1 #

Total comments: 1

Patch Set 2 : update w/ review feedback #

Patch Set 3 : merge to r226807 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -38 lines) Patch
M masters/master.chromium.webkit/master_linux_webkit_latest_cfg.py View 3 chunks +12 lines, -3 lines 0 comments Download
M masters/master.chromium.webkit/master_linux_webkit_pinned_cfg.py View 1 chunk +4 lines, -1 line 0 comments Download
M masters/master.tryserver.chromium/master.cfg View 1 2 3 chunks +3 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium/config.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.32-to-linux.arm.32.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.32-to-linux.intel.32.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.32-to-linux.mips.32.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.64-to-linux.arm.32.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.64-to-linux.arm.64.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.64-to-linux.intel.32.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.64-to-linux.intel.64.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.64-to-linux.mips.32.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Debug-linux.intel.64-to-linux.mips.64.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.32-to-linux.arm.32.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.32-to-linux.intel.32.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.32-to-linux.mips.32.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.64-to-linux.arm.32.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.64-to-linux.arm.64.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.64-to-linux.intel.32.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.64-to-linux.intel.64.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.64-to-linux.mips.32.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium/config.expected/Release-linux.intel.64-to-linux.mips.64.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/linux_passFirst_debug.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/linux_passFirst_debug_git.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/linux_passFirst_release.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/linux_passFirst_release_git.json View 1 2 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/linux_passMinimal_debug.json View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/linux_passMinimal_debug_git.json View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/linux_passMinimal_release.json View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/linux_passMinimal_release_git.json View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/blink_trybot.expected/minimal_pass_continues.json View 1 2 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Dirk Pranke
7 years, 2 months ago (2013-10-02 20:46:08 UTC) #1
iannucci
lgtm https://codereview.chromium.org/25792002/diff/1/scripts/slave/recipe_modules/chromium/config.py File scripts/slave/recipe_modules/chromium/config.py (right): https://codereview.chromium.org/25792002/diff/1/scripts/slave/recipe_modules/chromium/config.py#newcode219 scripts/slave/recipe_modules/chromium/config.py:219: if c.TARGET_PLATFORM == 'win' or c.TARGET_PLATFORM == 'linux': ...
7 years, 2 months ago (2013-10-02 21:31:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/25792002/5001
7 years, 2 months ago (2013-10-03 20:48:01 UTC) #3
commit-bot: I haz the power
Failed to apply patch for build/scripts/slave/recipes/blink_trybot.expected/linux_fail_debug.json: While running patch -p1 --forward --force --no-backup-if-mismatch; can't find ...
7 years, 2 months ago (2013-10-03 20:48:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpranke@chromium.org/25792002/8001
7 years, 2 months ago (2013-10-03 21:22:02 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-03 21:23:34 UTC) #6
Message was sent while issue was closed.
Change committed as 226850

Powered by Google App Engine
This is Rietveld 408576698