Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 257913002: Move querySelector*() API to ParentNode.idl (Closed)

Created:
6 years, 8 months ago by Inactive
Modified:
6 years, 8 months ago
CC:
blink-reviews, chrishtr, arv+blink, sof, eae+blinkwatch, ojan, dglazkov+blink, adamk+blink_chromium.org, rwlbuis, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Move querySelector*() API to ParentNode.idl Move querySelector*() API to ParentNode.idl to match the specification and avoid duplicating the same IDL in Document / DocumentFragment / Element: http://dom.spec.whatwg.org/#parentnode R=arv@chromium.org, haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172679

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -11 lines) Patch
M Source/core/dom/Document.idl View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/dom/DocumentFragment.idl View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/dom/Element.idl View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/dom/ParentNode.h View 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/dom/ParentNode.idl View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Inactive
6 years, 8 months ago (2014-04-25 15:27:58 UTC) #1
haraken
LGTM
6 years, 8 months ago (2014-04-25 15:29:22 UTC) #2
arv (Not doing code reviews)
mLGTM
6 years, 8 months ago (2014-04-25 15:31:53 UTC) #3
arv (Not doing code reviews)
LGTM
6 years, 8 months ago (2014-04-25 15:31:58 UTC) #4
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 8 months ago (2014-04-25 15:32:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/257913002/1
6 years, 8 months ago (2014-04-25 15:33:12 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 15:40:23 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_rel
6 years, 8 months ago (2014-04-25 15:40:24 UTC) #8
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 8 months ago (2014-04-25 15:52:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/257913002/1
6 years, 8 months ago (2014-04-25 15:53:04 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 16:16:59 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 8 months ago (2014-04-25 16:16:59 UTC) #12
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 8 months ago (2014-04-25 17:24:26 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/257913002/1
6 years, 8 months ago (2014-04-25 17:24:59 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 17:57:11 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 8 months ago (2014-04-25 17:57:11 UTC) #16
Inactive
The CQ bit was checked by ch.dumez@samsung.com
6 years, 8 months ago (2014-04-25 21:50:45 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/257913002/1
6 years, 8 months ago (2014-04-25 22:10:12 UTC) #18
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 22:57:36 UTC) #19
Message was sent while issue was closed. 
Change committed as 172679

Powered by Google App Engine
This is Rietveld 408576698