Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Unified Diff: chrome/browser/policy/policy_browsertest.cc

Issue 2579013002: Disable flaky incognito-related tests on Mac ASAN. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/tracing/chrome_tracing_delegate_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/policy/policy_browsertest.cc
diff --git a/chrome/browser/policy/policy_browsertest.cc b/chrome/browser/policy/policy_browsertest.cc
index 15248b58cde52a8288a67c0ca2e0f6b13550023a..f306e0ad7a21a580689822fffc66b0d6802d9008 100644
--- a/chrome/browser/policy/policy_browsertest.cc
+++ b/chrome/browser/policy/policy_browsertest.cc
@@ -2094,7 +2094,13 @@ IN_PROC_BROWSER_TEST_F(PolicyTest, HomepageLocation) {
EXPECT_EQ(GURL(chrome::kChromeUINewTabURL), contents->GetURL());
}
-IN_PROC_BROWSER_TEST_F(PolicyTest, IncognitoEnabled) {
+#if defined(OS_MACOSX) && defined(ADDRESS_SANITIZER)
+// Flaky on ASAN on Mac. See https://crbug.com/674497.
+#define MAYBE_IncognitoEnabled DISABLED_IncognitoEnabled
+#else
+#define MAYBE_IncognitoEnabled IncognitoEnabled
+#endif
+IN_PROC_BROWSER_TEST_F(PolicyTest, MAYBE_IncognitoEnabled) {
// Verifies that incognito windows can't be opened when disabled by policy.
const BrowserList* active_browser_list = BrowserList::GetInstance();
« no previous file with comments | « no previous file | chrome/browser/tracing/chrome_tracing_delegate_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698