Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm

Issue 2578973002: Reload offline version on load failure (Closed)
Patch Set: rebase + const Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/ui/reading_list/reading_list_side_swipe_provider.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm
diff --git a/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm b/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm
index c7e64f015999d850520013f2e6df640e22a4e99a..f50c5bde29526363c4d9631ae23a97a4f3e1f7bc 100644
--- a/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm
+++ b/ios/chrome/browser/ui/reading_list/reading_list_view_controller.mm
@@ -19,7 +19,6 @@
#include "components/url_formatter/url_formatter.h"
#include "ios/chrome/browser/reading_list/offline_url_utils.h"
#include "ios/chrome/browser/reading_list/reading_list_download_service.h"
-#include "ios/chrome/browser/reading_list/reading_list_entry_loading_util.h"
#import "ios/chrome/browser/tabs/tab.h"
#import "ios/chrome/browser/tabs/tab_model.h"
#import "ios/chrome/browser/ui/alert_coordinator/action_sheet_coordinator.h"
@@ -433,8 +432,9 @@ using ItemsMapByDate = std::multimap<int64_t, ReadingListCollectionViewItem*>;
Tab* currentTab = _tabModel.currentTab;
DCHECK(currentTab);
- reading_list::LoadReadingListEntry(*entry, self.readingListModel,
- currentTab.webState);
+ web::NavigationManager::WebLoadParams params(entry->URL());
+ params.transition_type = ui::PageTransition::PAGE_TRANSITION_AUTO_BOOKMARK;
+ [currentTab webState]->GetNavigationManager()->LoadURLWithParams(params);
[self dismiss];
}
« no previous file with comments | « ios/chrome/browser/ui/reading_list/reading_list_side_swipe_provider.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698