third_party/WebKit/Source/bindings/scripts/v8_attributes.py - Issue 2578943002: [Bindings] Refactoring of binding code around runtime enabled features

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_attributes.py

Issue 2578943002: [Bindings] Refactoring of binding code around runtime enabled features (Closed)

Patch Set: . Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/code_generator.py ('k') | third_party/WebKit/Source/bindings/scripts/v8_dictionary.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/scripts/v8_attributes.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_attributes.py b/third_party/WebKit/Source/bindings/scripts/v8_attributes.py

index ee98822f6c78577b8680c2e6742fa6a4c67a9f7a..8892fe92d57ae38ae6336e72f14f87123b093f59 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_attributes.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_attributes.py

@@ -180,8 +180,7 @@ def attribute_context(interface, attribute, interfaces):

'reflect_invalid': extended_attributes.get('ReflectInvalid', ''),

'reflect_missing': extended_attributes.get('ReflectMissing'),

'reflect_only': extended_attribute_value_as_list(attribute, 'ReflectOnly'),

- 'runtime_enabled_function': v8_utilities.runtime_enabled_function_name(attribute), # [RuntimeEnabled]

- 'runtime_feature_name': v8_utilities.runtime_feature_name(attribute), # [RuntimeEnabled]

+ 'runtime_enabled': v8_utilities.runtime_feature_name(attribute), # [RuntimeEnabled]

Yuki 2016/12/15 11:56:39 nit: 'runtime_enabled' sounds to me like a boolean

peria 2016/12/16 05:27:04 Done.

'secure_context_test': v8_utilities.secure_context(attribute, interface), # [SecureContext]

'cached_accessor_name': '%s%sCachedAccessor' % (interface.name, attribute.name.capitalize()),

'world_suffixes': (

@@ -217,7 +216,7 @@ def filter_accessors(attributes):

not (attribute['exposed_test'] or

attribute['secure_context_test'] or

attribute['origin_trial_enabled_function'] or

- attribute['runtime_enabled_function']) and

+ attribute['runtime_enabled']) and

not attribute['is_data_type_property']]

@@ -225,7 +224,7 @@ def is_data_attribute(attribute):

return (not (attribute['exposed_test'] or

attribute['secure_context_test'] or

attribute['origin_trial_enabled_function'] or

- attribute['runtime_enabled_function']) and

+ attribute['runtime_enabled']) and

attribute['is_data_type_property'])

@@ -251,7 +250,7 @@ def filter_runtime_enabled(attributes):

return [attribute for attribute in attributes if

not (attribute['exposed_test'] or

attribute['secure_context_test']) and

- attribute['runtime_feature_name']]

+ attribute['runtime_enabled']]

################################################################################