Gold support in PDFium

testing/tools/common.py

 #!/usr/bin/env python
 # Copyright 2015 The PDFium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import glob
 import os
 import subprocess
 import sys
 
 def os_name():
   if sys.platform.startswith('linux'):
     return 'linux'
   if sys.platform.startswith('win'):
     return 'win'
   if sys.platform.startswith('darwin'):
     return 'mac'
   raise Exception('Confused, can not determine OS, aborting.')
 
 
 def RunCommand(cmd):
   try:
     subprocess.check_call(cmd)
     return None
   except subprocess.CalledProcessError as e:
     return e
 
+# RunCommandExtractHashedFiles returns a tuple: (raised_exception, hashed_files)

[borenet, 2016/12/21 19:47:28]

Isn't it more idiomatic just to let the exception propagate?

[stephana, 2016/12/21 21:47:57]

I agree, but I wanted the changes to be minimal to avoid breaking 
the already working tests, so I kept with the pattern for the existing 
codebase. 

+# It runs the given command. If it fails it will return an exception and None.
+# If it succeeds it will return None and the list of processed files extracted
+# from the output of the command. It expects lines in this format:
+#    MD5:<path_to_image_file>:<md5_hash_in_hex>
+# The returned hashed_files is a list of (file_path, MD5-hash) pairs.
+def RunCommandExtractHashedFiles(cmd):
+  try:
+    output = subprocess.check_output(cmd, universal_newlines=True)
+    ret = []
+    for line in output.split('\n'):
+      line = line.strip()
+      if line.startswith("MD5:"):
+          ret.append([x.strip() for x in line.lstrip("MD5:").rsplit(":", 1)])
+    return None, ret
+  except subprocess.CalledProcessError as e:
+    return e, None
+
 # Adjust Dr. Memory wrapper to have separate log directory for each test
 # for better error reporting.
 def DrMemoryWrapper(wrapper, pdf_name):
   if not wrapper:
     return []
   # convert string to list
   cmd_to_run = wrapper.split()
 
   # Do nothing if using default log directory.
   if cmd_to_run.count("-logdir") == 0:
@@ skipping 65 matching lines @@
     if other_components:
       result = os.path.join(result, other_components)
     return result
 
   def TestingDir(self, other_components=''):
     '''Finds test files somewhere under the testing directory.'''
     result = self.testing_dir
     if other_components:
       result = os.path.join(result, other_components)
     return result