Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: chrome/browser/safe_browsing/ui_manager.cc

Issue 2578873003: Remove certificate reporting code from SafeBrowsing ping and ui managers (Closed)
Patch Set: Rebase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/ui_manager.cc
diff --git a/chrome/browser/safe_browsing/ui_manager.cc b/chrome/browser/safe_browsing/ui_manager.cc
index 877b23f5059f1335b88b640670d463b6d6b69241..9baab76fa01dc728b10e585880041f334733440f 100644
--- a/chrome/browser/safe_browsing/ui_manager.cc
+++ b/chrome/browser/safe_browsing/ui_manager.cc
@@ -200,18 +200,6 @@ void SafeBrowsingUIManager::ReportSafeBrowsingHitOnIOThread(
sb_service_->ping_manager()->ReportSafeBrowsingHit(hit_report);
}
-void SafeBrowsingUIManager::ReportInvalidCertificateChain(
- const std::string& serialized_report,
- const base::Closure& callback) {
- DCHECK_CURRENTLY_ON(BrowserThread::UI);
- BrowserThread::PostTaskAndReply(
- BrowserThread::IO, FROM_HERE,
- base::Bind(
- &SafeBrowsingUIManager::ReportInvalidCertificateChainOnIOThread, this,
- serialized_report),
- callback);
-}
-
void SafeBrowsingUIManager::ReportPermissionAction(
const PermissionReportInfo& report_info) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
@@ -227,18 +215,6 @@ void SafeBrowsingUIManager::CreateWhitelistForTesting(
EnsureWhitelistCreated(web_contents);
}
-void SafeBrowsingUIManager::ReportInvalidCertificateChainOnIOThread(
- const std::string& serialized_report) {
- DCHECK_CURRENTLY_ON(BrowserThread::IO);
-
- // The service may delete the ping manager (i.e. when user disabling service,
- // etc). This happens on the IO thread.
- if (!sb_service_ || !sb_service_->ping_manager())
- return;
-
- sb_service_->ping_manager()->ReportInvalidCertificateChain(serialized_report);
-}
-
void SafeBrowsingUIManager::ReportPermissionActionOnIOThread(
const PermissionReportInfo& report_info) {
DCHECK_CURRENTLY_ON(BrowserThread::IO);
« no previous file with comments | « chrome/browser/safe_browsing/ui_manager.h ('k') | chrome/browser/ssl/captive_portal_blocking_page_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698