Implement Win 10 onboarding content logic

chrome/browser/ui/startup/startup_tab_provider.h

Index: chrome/browser/ui/startup/startup_tab_provider.h
diff --git a/chrome/browser/ui/startup/startup_tab_provider.h b/chrome/browser/ui/startup/startup_tab_provider.h
index 1a75d09250cef9796609c4b66354e4904cc972f8..1afcb5fba332dc6ab6b7103e8f9771932a33c28c 100644
--- a/chrome/browser/ui/startup/startup_tab_provider.h
+++ b/chrome/browser/ui/startup/startup_tab_provider.h
@@ -58,13 +58,23 @@ class StartupTabProviderImpl : public StartupTabProvider {
   // the respective Get*Tabs methods, but do not gather or interact with any
   // system state relating to making those policy decisions.
 
-  // Determines which tabs which should be shown according to onboarding/first
+  // Determines which tabs should be shown according to onboarding/first
   // run policy.
   static StartupTabs CheckStandardOnboardingTabPolicy(
       bool is_first_run,
       bool has_seen_welcome_page,
       bool is_signed_in);
 
+#if defined(OS_WIN)

[Peter Kasting, 2016/12/16 08:53:55]

I have no detailed proposal here, but I don't love the #if OS_WINs in this
cross-platform code.  It might be nice to use a platform-specific subclass
instead to implement this sort of thing.

[Patrick Monette, 2016/12/16 19:02:18]

Yeah it's less than ideal but since there is only a small Windows exception, I
think it's better to keep it like this for simplicity than to create a subclass.

+  // Determines which tabs should be shown according to onboarding/first
+  // run policy, including promo content specific to Windows 10.
+  static StartupTabs CheckWin10OnboardingTabPolicy(bool is_first_run,
+                                                   bool has_seen_welcome_page,
+                                                   bool has_seen_win10_promo,
+                                                   bool is_signed_in,
+                                                   bool is_default_browser);
+#endif
+
   // Processes first run URLs specified in Master Preferences file, replacing
   // any "magic word" URL hosts with appropriate URLs.
   static StartupTabs CheckMasterPrefsTabPolicy(
@@ -96,6 +106,14 @@ class StartupTabProviderImpl : public StartupTabProvider {
   // additional profile).
   static GURL GetWelcomePageUrl(bool use_later_run_variant);
 
+#if defined(OS_WIN)
+  // Gets the URL for the Windows 10 Welcome page. If |use_later_run_variant| is
+  // true, a

[Peter Kasting, 2016/12/16 08:53:55]

Nit: rewrap

[Patrick Monette, 2016/12/16 19:02:18]

Done.

+  // URL parameter will be appended so as to access the variant page used when
+  // onboarding occurs after the first Chrome execution.
+  static GURL GetWin10WelcomePageUrl(bool use_later_run_variant);
+#endif
+
   // Gets the URL for the page which offers to reset the user's profile
   // settings.
   static GURL GetTriggeredResetSettingsUrl();