Made a generator for .h files for implementations of CSSPropertyAPI.h

third_party/WebKit/Source/build/scripts/make_css_property_api.py

 #!/usr/bin/env python
 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import sys
 
 import in_generator
 import template_expander
 import make_style_builder
@@ skipping 16 matching lines @@
     def __init__(self, in_file_path):
         super(CSSPropertyAPIWriter, self).__init__(in_file_path)
         self._outputs = {
             'CSSPropertyDescriptor.cpp': self.generate_property_descriptor_cpp,
         }
 
         # Temporary map of API classname to list of propertyIDs that the API class is for.
         properties_for_class = defaultdict(list)
         for property in self._properties.values():
             if property['api_class'] is None:
                 continue

[sashab, 2016/12/15 02:48:42]

Small thing - in your CL description, avoid 'we', use recipe-style language
instead 'To do X, do Y...'

[aazzam, 2016/12/15 04:35:07]

done :)

             classname = get_classname(property)

[sashab, 2016/12/15 02:48:43]

Also this file - because it generates both, maybe:

make_css_property_apis.py
make_css_property_descriptors.py
make_css_property_apis_and_descriptors.py

Whatever makes more sense to you :) I think the first one is probably OK

[aazzam, 2016/12/15 04:35:07]

I've gone with make_css_property_apis.py, sounds OK and is not too long :)

             properties_for_class[classname].append(property['property_id'])
+            self._outputs.update({classname + '.h': self.generate_property_api_h_builder(classname)})

[sashab, 2016/12/15 02:48:43]

You don't need .update - you can just set [key] = [value] :)

[aazzam, 2016/12/15 04:35:07]

done :)

 
         # Stores a list of classes with elements (index, classname, [propertyIDs, ..]).
         self._api_classes = []
 
         ApiClass = namedtuple('ApiClass', ('index', 'classname', 'property_ids'))
         for i, classname in enumerate(properties_for_class.keys()):
             self._api_classes.append(ApiClass(
                 index=i + 1,
                 classname=classname,
                 property_ids=properties_for_class[classname]
             ))
 
     @template_expander.use_jinja('CSSPropertyDescriptor.cpp.tmpl')
     def generate_property_descriptor_cpp(self):
         return {
             'api_classes': self._api_classes,
         }
 
+    # The self._outputs dict requires a function pointer to a generation function for
+    # each .h file. This generation function is different depending on which property
+    # group we are generating a .h file for. Therefore we have generate_api_function
+    # which generates a new function pointer given the classname and property ids.

[sashab, 2016/12/15 02:48:42]

Great comment, except one nit: 'function pointer' is not really the right word
in Python since pointers don't exist lol ;) I'd say function object instead.

Can probably shorten it a bit too - see if you can do that without losing
meaning :)

[aazzam, 2016/12/15 04:35:07]

re-worded it, does this sound better?

+    def generate_property_api_h_builder(self, api_classname):
+        @template_expander.use_jinja('CSSPropertyAPI.h.tmpl')
+        def generate_property_api_h():
+            return {
+                'api_classname': api_classname,
+            }
+        return generate_property_api_h
+
 if __name__ == '__main__':
     in_generator.Maker(CSSPropertyAPIWriter).main(sys.argv)