Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: third_party/WebKit/Source/core/editing/Editor.h

Issue 2578753002: [EditCommandSource] Rename and move |EditorCommandSource| to "CompositeEditCommand.h" (1/3) (Closed)
Patch Set: Xiaocheng and tkent's review: Rename to |EditCommandSource| and use kCamelCase Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/editing/Editor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/Editor.h
diff --git a/third_party/WebKit/Source/core/editing/Editor.h b/third_party/WebKit/Source/core/editing/Editor.h
index eedc2c7f91ab0d579b079ba8fd14fca322c62792..e34b28dadf360525899a6f16aaee725ef0e5e726 100644
--- a/third_party/WebKit/Source/core/editing/Editor.h
+++ b/third_party/WebKit/Source/core/editing/Editor.h
@@ -57,12 +57,12 @@ class StylePropertySet;
class TextEvent;
class UndoStack;
+enum class EditCommandSource;
enum class DeleteDirection;
enum class DeleteMode { Simple, Smart };
enum class InsertMode { Simple, Smart };
enum class DragSourceType { HTMLSource, PlainTextSource };
-enum EditorCommandSource { CommandFromMenuOrKeyBinding, CommandFromDOM };
enum EditorParagraphSeparator {
EditorParagraphSeparatorIsDiv,
EditorParagraphSeparatorIsP
@@ -94,10 +94,10 @@ class CORE_EXPORT Editor final : public GarbageCollectedFinalized<Editor> {
bool canDelete() const;
bool canSmartCopyOrDelete() const;
- void cut(EditorCommandSource);
+ void cut(EditCommandSource);
void copy();
- void paste(EditorCommandSource);
- void pasteAsPlainText(EditorCommandSource);
+ void paste(EditCommandSource);
+ void pasteAsPlainText(EditCommandSource);
void performDelete();
static void countEvent(ExecutionContext*, const Event*);
@@ -142,7 +142,7 @@ class CORE_EXPORT Editor final : public GarbageCollectedFinalized<Editor> {
public:
Command();
- Command(const EditorInternalCommand*, EditorCommandSource, LocalFrame*);
+ Command(const EditorInternalCommand*, EditCommandSource, LocalFrame*);
bool execute(const String& parameter = String(),
Event* triggeringEvent = nullptr) const;
@@ -170,13 +170,13 @@ class CORE_EXPORT Editor final : public GarbageCollectedFinalized<Editor> {
RangeVector* getTargetRanges() const;
const EditorInternalCommand* m_command;
- EditorCommandSource m_source;
+ EditCommandSource m_source;
Member<LocalFrame> m_frame;
};
- Command createCommand(
- const String&
- commandName); // Command source is CommandFromMenuOrKeyBinding.
- Command createCommand(const String& commandName, EditorCommandSource);
+ // Command source is |EditCommandSource::kMenuOrKeyBinding|.
+ Command createCommand(const String& commandName);
+ // Command source is |EditCommandSource::kDOM|.
+ Command createCommandFromDOM(const String& commandName);
// |Editor::executeCommand| is implementation of |WebFrame::executeCommand|
// rather than |Document::execCommand|.
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.cpp ('k') | third_party/WebKit/Source/core/editing/Editor.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698