Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: third_party/WebKit/Source/core/editing/Editor.h

Issue 2578753002: [EditCommandSource] Rename and move |EditorCommandSource| to "CompositeEditCommand.h" (1/3) (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/Editor.h
diff --git a/third_party/WebKit/Source/core/editing/Editor.h b/third_party/WebKit/Source/core/editing/Editor.h
index 41a5b49adfbada602f5f88053a4315443332699a..ad6ae5d9d47a244221214b480dfbfd742e0cdd6a 100644
--- a/third_party/WebKit/Source/core/editing/Editor.h
+++ b/third_party/WebKit/Source/core/editing/Editor.h
@@ -57,12 +57,12 @@ class StylePropertySet;
class TextEvent;
class UndoStack;
+enum class CommandSource;
enum class DeleteDirection;
enum class DeleteMode { Simple, Smart };
enum class InsertMode { Simple, Smart };
enum class DragSourceType { HTMLSource, PlainTextSource };
-enum EditorCommandSource { CommandFromMenuOrKeyBinding, CommandFromDOM };
enum EditorParagraphSeparator {
EditorParagraphSeparatorIsDiv,
EditorParagraphSeparatorIsP
@@ -94,10 +94,10 @@ class CORE_EXPORT Editor final : public GarbageCollectedFinalized<Editor> {
bool canDelete() const;
bool canSmartCopyOrDelete() const;
- void cut(EditorCommandSource);
+ void cut(CommandSource);
void copy();
- void paste(EditorCommandSource);
- void pasteAsPlainText(EditorCommandSource);
+ void paste(CommandSource);
+ void pasteAsPlainText(CommandSource);
void performDelete();
static void countEvent(ExecutionContext*, const Event*);
@@ -142,7 +142,7 @@ class CORE_EXPORT Editor final : public GarbageCollectedFinalized<Editor> {
public:
Command();
- Command(const EditorInternalCommand*, EditorCommandSource, LocalFrame*);
+ Command(const EditorInternalCommand*, CommandSource, LocalFrame*);
bool execute(const String& parameter = String(),
Event* triggeringEvent = nullptr) const;
@@ -170,13 +170,13 @@ class CORE_EXPORT Editor final : public GarbageCollectedFinalized<Editor> {
RangeVector* getTargetRanges() const;
const EditorInternalCommand* m_command;
- EditorCommandSource m_source;
+ CommandSource m_source;
Member<LocalFrame> m_frame;
};
- Command createCommand(
- const String&
- commandName); // Command source is CommandFromMenuOrKeyBinding.
- Command createCommand(const String& commandName, EditorCommandSource);
+ // Command source is |CommandSource::MenuOrKeyBinding|.
+ Command createCommand(const String& commandName);
+ // Command source is |CommandSource::Dom|.
+ Command createCommandFromDOM(const String& commandName);
// |Editor::executeCommand| is implementation of |WebFrame::executeCommand|
// rather than |Document::execCommand|.

Powered by Google App Engine
This is Rietveld 408576698