move CommandLineParser into analyzer for reuse by DDC

move CommandLineParser into analyzer for reuse by DDC

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/2c62510f5f1acd650be9e6c79b8ced2d6b1a26b0

[danrubel, 2016-12-14 20:54:35]

danrubel@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-12-14 21:05:10]

I would really prefer that we don't do this, because this class *really* needs
to go away, but if it makes it easier for you to make progress, then lgtm.

https://codereview.chromium.org/2578733002/diff/1/pkg/analyzer/lib/src/comman...
File pkg/analyzer/lib/src/command_line/command_line_parser.dart (right):

https://codereview.chromium.org/2578733002/diff/1/pkg/analyzer/lib/src/comman...
pkg/analyzer/lib/src/command_line/command_line_parser.dart:1: import
'package:args/args.dart';
Copyright

[danrubel, 2016-12-14 21:24:21]

On 2016/12/14 21:05:10, Brian Wilkerson wrote:
> I would really prefer that we don't do this, because this class *really* needs
> to go away, but if it makes it easier for you to make progress, then lgtm.

I agree that it would be better to
(1) drop support for --ignore-unrecognized-flags, or
(2) integrate this into ArgParser

Until then, we need it for both Analyzer CLI and DDC.

[Brian Wilkerson, 2016-12-14 21:25:49]

No, the argument utilities include a function for removing unsupported flags
before passing them to the args parser.

[danrubel, 2016-12-14 21:27:47]

On 2016/12/14 21:24:21, danrubel wrote:
> On 2016/12/14 21:05:10, Brian Wilkerson wrote:
> > I would really prefer that we don't do this, because this class *really*
needs
> > to go away, but if it makes it easier for you to make progress, then lgtm.
> 
> I agree that it would be better to
> (1) drop support for --ignore-unrecognized-flags, or
> (2) integrate this into ArgParser
> 
> Until then, we need it for both Analyzer CLI and DDC.

https://github.com/dart-lang/args/issues/9

[danrubel, 2016-12-14 21:28:07]

https://codereview.chromium.org/2578733002/diff/1/pkg/analyzer/lib/src/comman...
File pkg/analyzer/lib/src/command_line/command_line_parser.dart (right):

https://codereview.chromium.org/2578733002/diff/1/pkg/analyzer/lib/src/comman...
pkg/analyzer/lib/src/command_line/command_line_parser.dart:1: import
'package:args/args.dart';
On 2016/12/14 21:05:09, Brian Wilkerson wrote:
> Copyright

Good eyes. Done.

[danrubel, 2016-12-14 21:31:50]

Description was changed from

==========
move CommandLineParser into analyzer for reuse by DDC
==========

to

==========
move CommandLineParser into analyzer for reuse by DDC

R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/2c62510f5f1acd650be9e6c79b8ced2d6b1a26b0
==========

[danrubel, 2016-12-14 21:31:51]

Committed patchset #3 (id:40001) manually as
2c62510f5f1acd650be9e6c79b8ced2d6b1a26b0 (presubmit successful).