Add missing views_unittests target to chromium trybot.

Add missing views_unittests target to chromium trybot.

It caused the patch in https://codereview.chromium.org/248763003/ to be
reverted and probably some others too.

BUG=None
TEST=green trybots
R=phajdan.jr@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266990

[tfarina, 2014-04-25 23:17:22]

Pawel, ptal.

Sadrul, Scott, Trent, fyi.

[sky, 2014-04-25 23:24:59]

https://codereview.chromium.org/257873004/diff/1/testing/buildbot/chromium_tr...
File testing/buildbot/chromium_trybot.json (right):

https://codereview.chromium.org/257873004/diff/1/testing/buildbot/chromium_tr...
testing/buildbot/chromium_trybot.json:63: "platforms": ["linux", "win"]
Does linux include chromeos?

[tfarina, 2014-04-25 23:30:07]

https://codereview.chromium.org/257873004/diff/1/testing/buildbot/chromium_tr...
File testing/buildbot/chromium_trybot.json (right):

https://codereview.chromium.org/257873004/diff/1/testing/buildbot/chromium_tr...
testing/buildbot/chromium_trybot.json:63: "platforms": ["linux", "win"]
On 2014/04/25 23:25:00, sky wrote:
> Does linux include chromeos?
I will let Pawel answer that as I don't know myself. I don't know all the values
"platforms" support other than "linux", "win" and "mac".

[Paweł Hajdan Jr., 2014-04-28 11:01:11]

https://codereview.chromium.org/257873004/diff/1/testing/buildbot/chromium_tr...
File testing/buildbot/chromium_trybot.json (right):

https://codereview.chromium.org/257873004/diff/1/testing/buildbot/chromium_tr...
testing/buildbot/chromium_trybot.json:63: "platforms": ["linux", "win"]
On 2014/04/25 23:25:00, sky wrote:
> Does linux include chromeos?

Yes.

https://codereview.chromium.org/257873004/diff/60001/testing/buildbot/chromiu...
File testing/buildbot/chromium_trybot.json (right):

https://codereview.chromium.org/257873004/diff/60001/testing/buildbot/chromiu...
testing/buildbot/chromium_trybot.json:63: "platforms": ["chromiumos", "win"]
There is no chromiumos platform.

You may need two entries for view_unittests:

1. platforms: win
2. platforms: linux + chromium_configs: (chromeos configs)

[tfarina, 2014-04-28 13:30:57]

https://codereview.chromium.org/257873004/diff/60001/testing/buildbot/chromiu...
File testing/buildbot/chromium_trybot.json (right):

https://codereview.chromium.org/257873004/diff/60001/testing/buildbot/chromiu...
testing/buildbot/chromium_trybot.json:63: "platforms": ["chromiumos", "win"]
On 2014/04/28 11:01:12, Paweł Hajdan Jr. wrote:
> There is no chromiumos platform.
> 
> You may need two entries for view_unittests:
> 
> 1. platforms: win
> 2. platforms: linux + chromium_configs: (chromeos configs)

Please, see if I got this right.

[Paweł Hajdan Jr., 2014-04-29 15:22:39]

LGTM

[tfarina, 2014-04-29 16:05:18]

The CQ bit was checked by tfarina@chromium.org

[commit-bot: I haz the power, 2014-04-29 16:06:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tfarina@chromium.org/257873004/120001

[commit-bot: I haz the power, 2014-04-29 23:12:52]

Change committed as 266990

[sky, 2014-04-30 21:27:51]

https://codereview.chromium.org/257873004/diff/120001/testing/buildbot/chromi...
File testing/buildbot/chromium_trybot.json (right):

https://codereview.chromium.org/257873004/diff/120001/testing/buildbot/chromi...
testing/buildbot/chromium_trybot.json:68: "chromium_configs":
["chromium_chromeos", "chromium_chromeos_clang"]
Sorry for the delayed question. Why the chromium_configs here? Shouldn't
platforms ["win", "linux"] on 63 be enough and no need for this section (65-69)?

[tfarina, 2014-05-01 17:07:26]

On 2014/04/30 21:27:51, sky wrote:
>
https://codereview.chromium.org/257873004/diff/120001/testing/buildbot/chromi...
> File testing/buildbot/chromium_trybot.json (right):
> 
>
https://codereview.chromium.org/257873004/diff/120001/testing/buildbot/chromi...
> testing/buildbot/chromium_trybot.json:68: "chromium_configs":
> ["chromium_chromeos", "chromium_chromeos_clang"]
> Sorry for the delayed question. Why the chromium_configs here? Shouldn't
> platforms ["win", "linux"] on 63 be enough and no need for this section
(65-69)?

Patch set 2 was that way, but linux didn't like the test results:
http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...
Some tests failed there:
http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...

[sky, 2014-05-01 19:24:55]

Please file a bug on this. AFAICT we should run this on all linux/chromeos
bots.

  -Scott

On Thu, May 1, 2014 at 10:07 AM,  <tfarina@chromium.org> wrote:
> On 2014/04/30 21:27:51, sky wrote:
>
>
https://codereview.chromium.org/257873004/diff/120001/testing/buildbot/chromi...
>>
>> File testing/buildbot/chromium_trybot.json (right):
>
>
>
>
https://codereview.chromium.org/257873004/diff/120001/testing/buildbot/chromi...
>>
>> testing/buildbot/chromium_trybot.json:68: "chromium_configs":
>> ["chromium_chromeos", "chromium_chromeos_clang"]
>> Sorry for the delayed question. Why the chromium_configs here? Shouldn't
>> platforms ["win", "linux"] on 63 be enough and no need for this section
>
> (65-69)?
>
> Patch set 2 was that way, but linux didn't like the test results:
>
http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...
> Some tests failed there:
>
http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...
>
> https://codereview.chromium.org/257873004/

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[tfarina, 2014-05-01 22:17:51]

On Thu, May 1, 2014 at 4:24 PM, Scott Violet <sky@chromium.org> wrote:

> Please file a bug on this. AFAICT we should run this on all linux/chromeos
> bots.
>
> Sure, bug filed. crbug.com/369289

-- 
Thiago Farina

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.