chrome/browser/browsing_data/browsing_data_remover_browsertest.cc - Issue 2578723002: Reduce BrowsingDataRemover's dependencies on Chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browsing_data/browsing_data_remover_browsertest.cc

Issue 2578723002: Reduce BrowsingDataRemover's dependencies on Chrome (Closed)

Patch Set: A new callsite appeared through rebase - fixed the compilation error. Created 3 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/browsing_data/browsing_data_remover_browsertest.cc

diff --git a/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc b/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc

index 173c759bc9b096b148928689d722100ff432d7a9..76f890f08150f3ad3b0e53cb14a014686a97b8c9 100644

--- a/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc

+++ b/chrome/browser/browsing_data/browsing_data_remover_browsertest.cc

@@ -116,7 +116,7 @@ class BrowsingDataRemoverBrowserTest : public InProcessBrowserTest {

BrowsingDataRemoverFactory::GetForBrowserContext(browser()->profile());

BrowsingDataRemoverCompletionObserver completion_observer(remover);

remover->RemoveAndReply(

- BrowsingDataRemover::Period(browsing_data::LAST_HOUR), remove_mask,

+ base::Time(), base::Time::Max(), remove_mask,

BrowsingDataHelper::UNPROTECTED_WEB, &completion_observer);

completion_observer.BlockUntilCompletion();

}

@@ -128,7 +128,7 @@ class BrowsingDataRemoverBrowserTest : public InProcessBrowserTest {

BrowsingDataRemoverFactory::GetForBrowserContext(browser()->profile());

BrowsingDataRemoverCompletionObserver completion_observer(remover);

remover->RemoveWithFilterAndReply(

- BrowsingDataRemover::Period(browsing_data::LAST_HOUR), remove_mask,

+ base::Time(), base::Time::Max(), remove_mask,

BrowsingDataHelper::UNPROTECTED_WEB, std::move(filter_builder),

&completion_observer);

completion_observer.BlockUntilCompletion();