Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2091)

Side by Side Diff: chrome/browser/android/preferences/pref_service_bridge.cc

Issue 2578723002: Reduce BrowsingDataRemover's dependencies on Chrome (Closed)
Patch Set: A new callsite appeared through rebase - fixed the compilation error. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/android/signin/signin_manager_android.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/preferences/pref_service_bridge.h" 5 #include "chrome/browser/android/preferences/pref_service_bridge.h"
6 6
7 #include <jni.h> 7 #include <jni.h>
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 650 matching lines...) Expand 10 before | Expand all | Expand 10 after
661 int filterable_mask = 661 int filterable_mask =
662 remove_mask & BrowsingDataRemover::IMPORTANT_SITES_DATATYPES; 662 remove_mask & BrowsingDataRemover::IMPORTANT_SITES_DATATYPES;
663 int nonfilterable_mask = remove_mask & 663 int nonfilterable_mask = remove_mask &
664 ~BrowsingDataRemover::IMPORTANT_SITES_DATATYPES; 664 ~BrowsingDataRemover::IMPORTANT_SITES_DATATYPES;
665 665
666 // ClearBrowsingDataObserver deletes itself when |browsing_data_remover| is 666 // ClearBrowsingDataObserver deletes itself when |browsing_data_remover| is
667 // done with both removal tasks. 667 // done with both removal tasks.
668 ClearBrowsingDataObserver* observer = new ClearBrowsingDataObserver( 668 ClearBrowsingDataObserver* observer = new ClearBrowsingDataObserver(
669 env, obj, browsing_data_remover, 2 /* tasks_count */); 669 env, obj, browsing_data_remover, 2 /* tasks_count */);
670 670
671 browsing_data::TimePeriod period =
672 static_cast<browsing_data::TimePeriod>(time_period);
673 browsing_data::RecordDeletionForPeriod(period);
674
671 if (filterable_mask) { 675 if (filterable_mask) {
672 browsing_data_remover->RemoveWithFilterAndReply( 676 browsing_data_remover->RemoveWithFilterAndReply(
673 BrowsingDataRemover::Period( 677 browsing_data::CalculateBeginDeleteTime(period),
674 static_cast<browsing_data::TimePeriod>(time_period)), 678 browsing_data::CalculateEndDeleteTime(period),
675 filterable_mask, BrowsingDataHelper::UNPROTECTED_WEB, 679 filterable_mask, BrowsingDataHelper::UNPROTECTED_WEB,
676 std::move(filter_builder), observer); 680 std::move(filter_builder), observer);
677 } else { 681 } else {
678 // Make sure |observer| doesn't wait for the filtered task. 682 // Make sure |observer| doesn't wait for the filtered task.
679 observer->OnBrowsingDataRemoverDone(); 683 observer->OnBrowsingDataRemoverDone();
680 } 684 }
681 685
682 if (nonfilterable_mask) { 686 if (nonfilterable_mask) {
683 browsing_data_remover->RemoveAndReply( 687 browsing_data_remover->RemoveAndReply(
684 BrowsingDataRemover::Period( 688 browsing_data::CalculateBeginDeleteTime(period),
685 static_cast<browsing_data::TimePeriod>(time_period)), 689 browsing_data::CalculateEndDeleteTime(period),
686 nonfilterable_mask, BrowsingDataHelper::UNPROTECTED_WEB, observer); 690 nonfilterable_mask, BrowsingDataHelper::UNPROTECTED_WEB, observer);
687 } else { 691 } else {
688 // Make sure |observer| doesn't wait for the non-filtered task. 692 // Make sure |observer| doesn't wait for the non-filtered task.
689 observer->OnBrowsingDataRemoverDone(); 693 observer->OnBrowsingDataRemoverDone();
690 } 694 }
691 } 695 }
692 696
693 static jboolean CanDeleteBrowsingHistory(JNIEnv* env, 697 static jboolean CanDeleteBrowsingHistory(JNIEnv* env,
694 const JavaParamRef<jobject>& obj) { 698 const JavaParamRef<jobject>& obj) {
695 return GetPrefService()->GetBoolean(prefs::kAllowDeletingBrowserHistory); 699 return GetPrefService()->GetBoolean(prefs::kAllowDeletingBrowserHistory);
(...skipping 517 matching lines...) Expand 10 before | Expand all | Expand 10 after
1213 1217
1214 return ConvertJavaStringToUTF8(android_permission); 1218 return ConvertJavaStringToUTF8(android_permission);
1215 } 1219 }
1216 1220
1217 static void SetSupervisedUserId(JNIEnv* env, 1221 static void SetSupervisedUserId(JNIEnv* env,
1218 const JavaParamRef<jobject>& obj, 1222 const JavaParamRef<jobject>& obj,
1219 const JavaParamRef<jstring>& pref) { 1223 const JavaParamRef<jstring>& pref) {
1220 GetPrefService()->SetString(prefs::kSupervisedUserId, 1224 GetPrefService()->SetString(prefs::kSupervisedUserId,
1221 ConvertJavaStringToUTF8(env, pref)); 1225 ConvertJavaStringToUTF8(env, pref));
1222 } 1226 }
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/android/signin/signin_manager_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698