Issue 257863002: Prototype API for accessing AST nodes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 257863002: Prototype API for accessing AST nodes. (Closed)

Created:
6 years, 8 months ago by ahe

Modified:
5 years, 10 months ago

Reviewers:
Johnni Winther, kevmoo

CC:
reviews_dartlang.org, sra1, Emily Fortuna

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Prototype API for accessing AST nodes. Includes sample that illustrates use. BUG=http://dartbug.com/18346

Patch Set 1 #

Total comments: 2

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+188 lines, -11 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart	View	2 chunks	+41 lines, -0 lines	2 comments	Download
A	dart/sdk/lib/_internal/compiler/samples/constants/constants.dart	View	1 chunk	+141 lines, -0 lines	0 comments	Download
A +	dart/sdk/lib/_internal/compiler/samples/constants/sample_input.dart	View	1 chunk	+6 lines, -11 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kevmoo

DBR https://codereview.chromium.org/257863002/diff/1/dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart File dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart (right): https://codereview.chromium.org/257863002/diff/1/dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart#newcode456 dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart:456: final node; Types here? Is nice...

6 years, 8 months ago (2014-04-25 12:58:11 UTC) #2

ahe

6 years, 8 months ago (2014-04-25 13:06:09 UTC) #3

https://codereview.chromium.org/257863002/diff/1/dart/sdk/lib/_internal/compi...
File dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart
(right):

https://codereview.chromium.org/257863002/diff/1/dart/sdk/lib/_internal/compi...
dart/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirrors.dart:456:
final node;
On 2014/04/25 12:58:11, kevmoo wrote:
> Types here? Is nice...

I didn't want to add types as I didn't want to add another import. However, the
library that defines the type is already imported :-)

I should also add a comment that describes the purpose of this class.

Expand Messages | Collapse Messages