Remove unused sysbtn code

xfa/fwl/fwl_widgetdef.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef XFA_FWL_FWL_WIDGETDEF_H_
 #define XFA_FWL_FWL_WIDGETDEF_H_
 
-#define FWL_WGTSTYLE_OverLapper (0L << 0)
+#define FWL_WGTSTYLE_OverLapper 0

[Tom Sepez, 2016/12/14 17:29:27]

Again, we've got a 2-bit field starting at 0.  How to communicate that in code? 
There ought to be a mask constant here that's part of how this is used ....

[dsinclair, 2016/12/14 17:48:13]

This file is cleaned up over several CLs. I'll shuffle this around at the end
...

 #define FWL_WGTSTYLE_Popup (1L << 0)
 #define FWL_WGTSTYLE_Child (2L << 0)
 #define FWL_WGTSTYLE_Border (1L << 2)
-#define FWL_WGTSTYLE_MinimizeBox (1L << 6)
-#define FWL_WGTSTYLE_MaximizeBox (1L << 7)
-#define FWL_WGTSTYLE_CloseBox (1L << 8)
 #define FWL_WGTSTYLE_HScroll (1L << 9)
 #define FWL_WGTSTYLE_VScroll (1L << 11)
 #define FWL_WGTSTYLE_LeftScrollbar (1L << 12)
 #define FWL_WGTSTYLE_LeftAlignment (0L << 13)

[Tom Sepez, 2016/12/14 17:29:27]

ditto here, except they're unused?

[dsinclair, 2016/12/14 17:48:13]

Acknowledged.

 #define FWL_WGTSTYLE_CenterAlignment (1L << 13)
 #define FWL_WGTSTYLE_RightAlignment (2L << 13)
 #define FWL_WGTSTYLE_TopAlignment (0L << 15)
 #define FWL_WGTSTYLE_VCenterAlignment (1L << 15)

[Tom Sepez, 2016/12/14 17:29:27]

and here, unused.

[dsinclair, 2016/12/14 17:48:13]

Acknowledged.

 #define FWL_WGTSTYLE_BottomAlignment (2L << 15)
 #define FWL_WGTSTYLE_RTLReading (1L << 17)
 #define FWL_WGTSTYLE_EdgeNone (0L << 19)
 #define FWL_WGTSTYLE_EdgeFlat (1L << 19)
 #define FWL_WGTSTYLE_EdgeRaised (2L << 19)
 #define FWL_WGTSTYLE_EdgeSunken (3L << 19)
 #define FWL_WGTSTYLE_EdgeMask (3L << 19)
 #define FWL_WGTSTYLE_Shadow (3L << 21)
 #define FWL_WGTSTYLE_Group (1L << 22)
 #define FWL_WGTSTYLE_TabStop (1L << 23)
 #define FWL_WGTSTYLE_Offscreen (1L << 24)
 #define FWL_WGTSTYLE_DragAcceptFiles (1L << 25)
 #define FWL_WGTSTYLE_TopMost (1L << 26)
 #define FWL_WGTSTYLE_TransParent (1L << 27)
 #define FWL_WGTSTYLE_NoBackground (1L << 28)
 #define FWL_WGTSTYLE_WindowTypeMask (3L << 0)

[Tom Sepez, 2016/12/14 17:29:27]

and here it is!  the mask constant, move to line 13.

[dsinclair, 2016/12/14 17:48:13]

Acknowledged.

 #define FWL_WGTSTATE_Restored (0L << 0)
 #define FWL_WGTSTATE_Minimized (1L << 0)
 #define FWL_WGTSTATE_Maximized (2L << 0)
 #define FWL_WGTSTATE_Disabled (1L << 2)
 #define FWL_WGTSTATE_Deactivated (1L << 3)
 #define FWL_WGTSTATE_Focused (1L << 4)
 #define FWL_WGTSTATE_Invisible (1L << 5)
 #define FWL_WGTSTATE_MAX (6)
 
 #define FWL_VKEY_LButton 0x01
@@ skipping 163 matching lines @@
 #define FWL_VKEY_Exsel 0xF8
 #define FWL_VKEY_Ereof 0xF9
 #define FWL_VKEY_Play 0xFA
 #define FWL_VKEY_Zoom 0xFB
 #define FWL_VKEY_NoName 0xFC
 #define FWL_VKEY_PA1 0xFD
 #define FWL_VKEY_OEM_Clear 0xFE
 #define FWL_VKEY_Unknown 0
 
 #endif  // XFA_FWL_FWL_WIDGETDEF_H_