Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: components/gcm_driver/common/gcm_messages.h

Issue 2578583002: Provide a mechanism for the GCM driver to send message receipts to GCM.
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/gcm_driver/gcm_client.h » ('j') | components/gcm_driver/gcm_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/gcm_driver/common/gcm_messages.h
diff --git a/components/gcm_driver/common/gcm_messages.h b/components/gcm_driver/common/gcm_messages.h
index 24be478e798f93195fc62a5ac017b9a73ff09501..d4328151875c62776a2fbf93ad7accbcfd4d3cc9 100644
--- a/components/gcm_driver/common/gcm_messages.h
+++ b/components/gcm_driver/common/gcm_messages.h
@@ -36,6 +36,9 @@ struct GCM_DRIVER_EXPORT IncomingMessage {
IncomingMessage(const IncomingMessage& other);
~IncomingMessage();
+ // Message ID.
+ std::string id;
Peter Beverloo 2016/12/15 19:24:24 I'd very much prefer not to expose the message ID
harkness 2016/12/21 17:23:37 Now that the callback is created in the GCMClient,
+
MessageData data;
std::string collapse_key;
std::string sender_id;
« no previous file with comments | « no previous file | components/gcm_driver/gcm_client.h » ('j') | components/gcm_driver/gcm_client.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698