Provide a mechanism for the GCM driver to send message receipts to GCM.

components/gcm_driver/gcm_client_impl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_GCM_DRIVER_GCM_CLIENT_IMPL_H_
 #define COMPONENTS_GCM_DRIVER_GCM_CLIENT_IMPL_H_
 
 #include <stdint.h>
 
 #include <map>
@@ skipping 33 matching lines @@
 
 namespace net {
 class HttpNetworkSession;
 }  // namespace net
 
 namespace gcm {
 
 class CheckinRequest;
 class ConnectionFactory;
 class GCMClientImplTest;
+enum class GCMMessageStatus;
 
 // Helper class for building GCM internals. Allows tests to inject fake versions
 // as necessary.
 class GCMInternalsBuilder {
  public:
   GCMInternalsBuilder();
   virtual ~GCMInternalsBuilder();
 
   virtual std::unique_ptr<base::Clock> BuildClock();
   virtual std::unique_ptr<MCSClient> BuildMCSClient(
@@ skipping 81 matching lines @@
 
   // GCMStatsRecorder::Delegate implemenation.
   void OnActivityRecorded() override;
 
   // ConnectionFactory::ConnectionListener implementation.
   void OnConnected(const GURL& current_server,
                    const net::IPEndPoint& ip_endpoint) override;
   void OnDisconnected() override;
 
  private:
+  // Send a message to GCM with information about the final status of a
+  // previously received message. This can be run as a result of a callback
+  // being executed from an AppHandler.
+  virtual void SendMessageReceipt(const std::string& message_id,

[Peter Beverloo, 2017/02/08 17:09:09]

This shouldn't be declared as `virtual` - nothing overrides it.

[harkness, 2017/02/09 16:27:30]

Done.

+                                  const std::string& app_id,
+                                  GCMMessageStatus status);
+
   // The check-in info for the device.
   // TODO(fgorski): Convert to a class with explicit getters/setters.
   struct CheckinInfo {
     CheckinInfo();
     ~CheckinInfo();
     bool IsValid() const { return android_id != 0 && secret != 0; }
     void SnapshotCheckinAccounts();
     void Reset();
 
     // Android ID of the device as assigned by the server.
@@ skipping 236 matching lines @@
 
   // Factory for creating references in callbacks.
   base::WeakPtrFactory<GCMClientImpl> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(GCMClientImpl);
 };
 
 }  // namespace gcm
 
 #endif  // COMPONENTS_GCM_DRIVER_GCM_CLIENT_IMPL_H_