Provide a mechanism for the GCM driver to send message receipts to GCM.

components/gcm_driver/gcm_client.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_GCM_DRIVER_GCM_CLIENT_H_
 #define COMPONENTS_GCM_DRIVER_GCM_CLIENT_H_
 
 #include <stdint.h>
 
 #include <map>
@@ skipping 53 matching lines @@
     // Network socket error.
     NETWORK_ERROR,
     // Problem at the server.
     SERVER_ERROR,
     // Exceeded the specified TTL during message sending.
     TTL_EXCEEDED,
     // Other errors.
     UNKNOWN_ERROR
   };
 
+  // Enumeration to be used for describing the final status of a GCM message.
+  enum GCMMessageStatus {

[Peter Beverloo, 2016/12/15 19:24:24]

Let's move this to its own file. It's not clear to me what usage like the
following means ("for what"):

    GCMClient::GCM_SUCCESS

[harkness, 2016/12/21 17:23:37]

currently still in the GCMClient, but I'm planning to move it. Next upload.

+    // 0 reserved for success.
+    GCM_SUCCESS = 0,
+
+    // 1 - 99 reserved for GCMClient and GCMDriver error status.

[Peter Beverloo, 2016/12/15 19:24:24]

nit: Let's make sure that we pull this separate from our class separation, and
have comments that can be reused elsewhere. ("The GCM Client"?)

[harkness, 2016/12/21 17:23:37]

Done.

+    GCM_INVALID_SUBTYPE = 1,
+    GCM_ENCRYPTION_FAILURE = 2,
+    GCM_UNKNOWN_MESSAGE_TYPE = 3,
+    GCM_NO_APP_HANDLER = 4,
+    GCM_INVALID_MESSAGE_TAG = 5,
+  };
+
   enum ChromePlatform {
     PLATFORM_WIN,
     PLATFORM_MAC,
     PLATFORM_LINUX,
     PLATFORM_CROS,
     PLATFORM_IOS,
     PLATFORM_ANDROID,
     PLATFORM_UNKNOWN
   };
 
@@ skipping 85 matching lines @@
     virtual void OnSendFinished(const std::string& app_id,
                                 const std::string& message_id,
                                 Result result) = 0;
 
     // Called when a message has been received.
     // |app_id|: application ID.
     // |message|: message received.
     virtual void OnMessageReceived(const std::string& app_id,
                                    const IncomingMessage& message) = 0;
 
+    // Called when there is an error processing a received message.
+    // |app_id|: application ID.
+    // |message_id|: id of the message received.
+    // |status|: error type.
+    virtual void OnMessageReceivedError(const std::string& app_id,
+                                        const std::string& message_id,
+                                        int status) = 0;
+
     // Called when some messages have been deleted from the server.
     // |app_id|: application ID.
     virtual void OnMessagesDeleted(const std::string& app_id) = 0;
 
     // Called when a message failed to send to the server.
     // |app_id|: application ID.
     // |send_error_detials|: Details of the send error event, like mesasge ID.
     virtual void OnMessageSendError(
         const std::string& app_id,
         const SendErrorDetails& send_error_details) = 0;
@@ skipping 139 matching lines @@
   // to be set, and allows that component to later revoke the setting. It should
   // be unique.
   virtual void AddHeartbeatInterval(const std::string& scope,
                                     int interval_ms) = 0;
   virtual void RemoveHeartbeatInterval(const std::string& scope) = 0;
 };
 
 }  // namespace gcm
 
 #endif  // COMPONENTS_GCM_DRIVER_GCM_CLIENT_H_