Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2578573003: Add dart:io stubs to ddc sdk, define dart.library.html (Closed)

Created:
4 years ago by vsm
Modified:
4 years ago
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add tests #

Total comments: 2

Patch Set 3 : Regen sum #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+61712 lines, -1307 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 1 2 79 chunks +15504 lines, -434 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 1 2 79 chunks +15504 lines, -434 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 1 2 7 chunks +15073 lines, -4 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 1 2 79 chunks +15504 lines, -434 lines 0 comments Download
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View 1 2 Binary file 0 comments Download
M pkg/dev_compiler/lib/src/compiler/compiler.dart View 1 2 1 chunk +4 lines, -0 lines 1 comment Download
M pkg/dev_compiler/test/browser/language_tests.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M pkg/dev_compiler/test/not_yet_strong_tests.dart View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M pkg/dev_compiler/tool/build_sdk.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M pkg/dev_compiler/tool/sdk_expected_errors.txt View 1 2 2 chunks +45 lines, -0 lines 0 comments Download
A tests/language_strong/conditional_import_string_test.dart View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
A tests/language_strong/conditional_import_test.dart View 1 2 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
vsm
4 years ago (2016-12-14 16:11:46 UTC) #3
vsm
https://codereview.chromium.org/2578573003/diff/10001/pkg/dev_compiler/lib/src/compiler/compiler.dart File pkg/dev_compiler/lib/src/compiler/compiler.dart (right): https://codereview.chromium.org/2578573003/diff/10001/pkg/dev_compiler/lib/src/compiler/compiler.dart#newcode102 pkg/dev_compiler/lib/src/compiler/compiler.dart:102: context.declaredVariables.define('dart.library.io', 'false'); FYI - I verified that the tests ...
4 years ago (2016-12-14 16:20:29 UTC) #5
Jennifer Messerly
LGTM!!!
4 years ago (2016-12-14 18:37:02 UTC) #6
Bob Nystrom
LGTM!
4 years ago (2016-12-14 20:23:36 UTC) #7
Brian Wilkerson
Not that I know a lot about what I'm looking at, but lgtm. https://codereview.chromium.org/2578573003/diff/20001/pkg/dev_compiler/lib/src/compiler/compiler.dart File ...
4 years ago (2016-12-14 20:28:41 UTC) #8
vsm
4 years ago (2016-12-14 20:34:45 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:20001) manually as
392c242df9e0838903f8d749db745b97b967819f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698