Issue 257853003: ObjectHashTable's key and WeakHashTable's key types are now Handle<Object> instead of Object*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 257853003: ObjectHashTable's key and WeakHashTable's key types are now Handle<Object> instead of Object*. (Closed)

Created:
6 years, 8 months ago by Igor Sheludko

Modified:
6 years, 8 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

ObjectHashTable's key and WeakHashTable's key types are now Handle<Object> instead of Object*. R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20982

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -39 lines)			Patch
M	src/mark-compact.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects.h	View	8 chunks	+26 lines, -18 lines	0 comments	Download
M	src/objects.cc	View	6 chunks	+39 lines, -7 lines	0 comments	Download
M	src/objects-inl.h	View	2 chunks	+18 lines, -11 lines	0 comments	Download
M	test/cctest/test-dictionary.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

Yang

On 2014/04/25 11:48:08, Igor Sheludko wrote: > PTAL #14 lgtm.

6 years, 8 months ago (2014-04-25 12:47:17 UTC) #2

Igor Sheludko

6 years, 8 months ago (2014-04-25 13:35:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20982 (presubmit successful).