Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Side by Side Diff: device/screen_orientation/public/interfaces/screen_orientation.mojom

Issue 2578503002: [DeviceService] Mojofy left screen orientation IPC messages. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 module device.mojom; 5 module device.mojom;
6 6
7 import "device/screen_orientation/public/interfaces/screen_orientation_lock_type s.mojom"; 7 import "device/screen_orientation/public/interfaces/screen_orientation_lock_type s.mojom";
8 8
9 interface ScreenOrientation { 9 interface ScreenOrientation {
10 LockOrientation(ScreenOrientationLockType orientation) => 10 LockOrientation(ScreenOrientationLockType orientation) =>
11 (ScreenOrientationLockResult result); 11 (ScreenOrientationLockResult result);
12 UnlockOrientation(); 12 UnlockOrientation();
13 }; 13 };
14
15 interface ScreenOrientationAccurate {
mlamouri (slow - plz ping) 2016/12/15 10:30:56 Can you add some documentation explaining why and
leonhsl(Using Gerrit) 2016/12/16 03:12:00 Acknowledged.
leonhsl(Using Gerrit) 2016/12/19 09:41:22 Done and Thanks!
16 // The renderer process is now using the Screen Orientation API and informs
17 // the browser process that it should start accurately listening to the screen
18 // orientation if it wasn't already.
19 // This is only expected to be acted upon when the underlying platform
20 // requires heavy work in order to accurately know the screen orientation.
mlamouri (slow - plz ping) 2016/12/15 10:30:57 I think you can remove these last two lines (some
leonhsl(Using Gerrit) 2016/12/16 03:12:00 Acknowledged.
leonhsl(Using Gerrit) 2016/12/19 09:41:22 Done.
21 StartListening();
22
23 // The renderer process is no longer using the Screen Orientation API and
24 // informs the browser process that it can stop accurately listening to the
25 // screen orientation if no other process cares about it.
26 // This is only expected to be acted upon when the underlying platform
27 // requires heavy work in order to accurately know the screen orientation.
28 StopListening();
29 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698