Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2139)

Unified Diff: extensions/browser/api/audio/audio_service.cc

Issue 2578473002: chrome.audio API: treat mute as system wide property (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/audio/audio_service.cc
diff --git a/extensions/browser/api/audio/audio_service.cc b/extensions/browser/api/audio/audio_service.cc
index ec4c7c131da1ee312a79aed35990683b694b1691..a2f266f422d7213f44e3dae2d486145e85c0a2b6 100644
--- a/extensions/browser/api/audio/audio_service.cc
+++ b/extensions/browser/api/audio/audio_service.cc
@@ -18,10 +18,12 @@ class AudioServiceImpl : public AudioService {
// Start to query audio device information.
bool GetInfo(OutputInfo* output_info_out, InputInfo* input_info_out) override;
void SetActiveDevices(const DeviceIdList& device_list) override;
- bool SetDeviceProperties(const std::string& device_id,
- bool muted,
+ bool SetDeviceSoundLevel(const std::string& device_id,
int volume,
int gain) override;
+ bool SetMuteForDevice(const std::string& device_id, bool value) override;
+ bool SetMute(bool is_input, bool value) override;
+ bool GetMute(bool is_input, bool* value) override;
};
void AudioServiceImpl::AddObserver(Observer* observer) {
@@ -45,11 +47,23 @@ bool AudioServiceImpl::GetInfo(OutputInfo* output_info_out,
void AudioServiceImpl::SetActiveDevices(const DeviceIdList& device_list) {
}
-bool AudioServiceImpl::SetDeviceProperties(const std::string& device_id,
- bool muted,
+bool AudioServiceImpl::SetDeviceSoundLevel(const std::string& device_id,
int volume,
int gain) {
return false;
}
+bool AudioServiceImpl::SetMuteForDevice(const std::string& device_id,
+ bool value) {
+ return false;
+}
+
+bool AudioServiceImpl::SetMute(bool is_input, bool value) {
+ return false;
+}
+
+bool AudioServiceImpl::GetMute(bool is_input, bool* value) {
+ return false;
+}
+
} // namespace extensions

Powered by Google App Engine
This is Rietveld 408576698