Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issue 2578463004: update DDC to use analyzer extractDefinedVariables (Closed)

Created:
4 years ago by danrubel
Modified:
4 years ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

update DDC to use analyzer extractDefinedVariables R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/1d4334739ce180cd71520907947cf33db0c3149b

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -27 lines) Patch
M pkg/dev_compiler/lib/src/analyzer/context.dart View 1 chunk +0 lines, -22 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/command.dart View 3 chunks +5 lines, -2 lines 0 comments Download
M pkg/dev_compiler/test/codegen_test.dart View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
danrubel
4 years ago (2016-12-14 18:28:34 UTC) #2
vsm
lgtm!
4 years ago (2016-12-15 00:23:14 UTC) #3
danrubel
4 years ago (2016-12-15 01:44:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
1d4334739ce180cd71520907947cf33db0c3149b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698