Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py - Issue 257843006: Run the expected output for RefTests with virtual test suite arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

Issue 257843006: Run the expected output for RefTests with virtual test suite arguments. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: reftests: skip Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

diff --git a/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py b/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

index 2d095901cf651a9a61a96d88430b1bd4cc2308d4..b50863f9e1f05312acaf69a552ebd5e3f41fcbb4 100644

--- a/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

+++ b/Tools/Scripts/webkitpy/layout_tests/controllers/single_test_runner.py

@@ -358,7 +358,7 @@ class SingleTestRunner(object):

for expectation, reference_filename in putAllMismatchBeforeMatch(self._reference_files):

reference_test_name = self._port.relative_test_filename(reference_filename)

reference_test_names.append(reference_test_name)

- driver_input = DriverInput(reference_test_name, self._timeout, image_hash=None, should_run_pixel_test=True, args=self._port.lookup_virtual_test_args(reference_test_name))

+ driver_input = DriverInput(reference_test_name, self._timeout, image_hash=None, should_run_pixel_test=True, args=self._port.lookup_virtual_test_args(self._test_name))

reference_output = self._driver.run_test(driver_input, self._stop_when_done)

test_result = self._compare_output_with_reference(reference_output, test_output, reference_filename, expectation == '!=')

« no previous file with comments | « LayoutTests/TestExpectations ('k') | no next file » | no next file with comments »