Add in resize logic for the non-badged icons.

chrome/browser/ui/views/profiles/avatar_menu_bubble_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/profiles/avatar_menu_bubble_view.h"
 
 #include <algorithm>
 
 #include "base/strings/string16.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 242 matching lines @@
                                  AvatarMenuBubbleView* parent,
                                  AvatarMenu* menu)
     : views::CustomButton(parent),
       item_(item),
       parent_(parent),
       menu_(menu) {
   set_notify_enter_exit_on_child(true);
 
   image_view_ = new ProfileImageView();
   gfx::ImageSkia profile_icon = *item_.icon.ToImageSkia();
-  if (item_.active || item_.signin_required)
+  if (item_.active || item_.signin_required) {
     image_view_->SetImage(GetBadgedIcon(profile_icon));
-  else
+  } else {
+    // The image may be too large are require resizing

[msw, 2014/04/28 17:56:52]

nit: s/are/and/; also add a period at the end.

[Mike Lerman, 2014/04/28 18:21:07]

Done.

+    image_view_->SetImageSize(

[msw, 2014/04/28 17:56:52]

Should this be set all the time, not just in this else case?

[Mike Lerman, 2014/04/28 18:21:07]

The other case, the GetBadgedIcon method, already does a scaling.

[msw, 2014/04/28 18:40:19]

Yeah, I saw that, but BadgeImageSource::ComputeSize seems to increase the
supplied sizes according to a badge overlap ratio; so their resulting composite
images could also be too large, afaict. Perhaps if the ImageView itself scales
the content, GetBadgedIcon could be simplified (but that's not strictly
necessary for this CL).

+        gfx::Size(profiles::kAvatarIconWidth, kItemHeight));
     image_view_->SetImage(profile_icon);
+  }
   AddChildView(image_view_);
 
   // Add a label to show the profile name.
   ui::ResourceBundle* rb = &ui::ResourceBundle::GetSharedInstance();
   name_label_ = new views::Label(item_.name,
                                  rb->GetFontList(item_.active ?
                                                  ui::ResourceBundle::BoldFont :
                                                  ui::ResourceBundle::BaseFont));
   name_label_->SetHorizontalAlignment(gfx::ALIGN_LEFT);
   AddChildView(name_label_);
@@ skipping 522 matching lines @@
   Layout();
   if (GetBubbleFrameView())
     SizeToContents();
 }
 
 void AvatarMenuBubbleView::SetBackgroundColors() {
   for (size_t i = 0; i < item_views_.size(); ++i) {
     item_views_[i]->OnHighlightStateChanged();
   }
 }