Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: chrome/browser/ui/tab_helpers.cc

Issue 2578363002: Wire up download attribution enable finch experiment (Closed)
Patch Set: nit Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/tab_helpers.cc
diff --git a/chrome/browser/ui/tab_helpers.cc b/chrome/browser/ui/tab_helpers.cc
index 74e762cf20c2e4276b868ce290ef36326b2ee490..ffee4de4b9a471067da3909af4e413c5b44e78c4 100644
--- a/chrome/browser/ui/tab_helpers.cc
+++ b/chrome/browser/ui/tab_helpers.cc
@@ -32,6 +32,7 @@
#include "chrome/browser/prerender/prerender_tab_helper.h"
#include "chrome/browser/previews/previews_infobar_tab_helper.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/safe_browsing/safe_browsing_service.h"
Avi (use Gerrit) 2016/12/20 02:44:26 It doesn't seem like you need this include.
Jialiu Lin 2016/12/20 03:16:54 Oops, sorry. I moved some checking logic and for
#include "chrome/browser/sessions/session_tab_helper.h"
#include "chrome/browser/ssl/security_state_tab_helper.h"
#include "chrome/browser/subresource_filter/chrome_subresource_filter_client.h"
@@ -77,6 +78,8 @@
#else
#include "chrome/browser/banners/app_banner_manager_desktop.h"
#include "chrome/browser/plugins/plugin_observer.h"
+#include "chrome/browser/safe_browsing/safe_browsing_navigation_observer.h"
+#include "chrome/browser/safe_browsing/safe_browsing_navigation_observer_manager.h"
Avi (use Gerrit) 2016/12/20 02:44:26 It doesn't seem like you need this include.
Jialiu Lin 2016/12/20 03:16:54 Done.
#include "chrome/browser/safe_browsing/safe_browsing_tab_observer.h"
#include "chrome/browser/thumbnails/thumbnail_tab_helper.h"
#include "chrome/browser/ui/bookmarks/bookmark_tab_helper.h"
@@ -228,6 +231,8 @@ void TabHelpers::AttachTabHelpers(WebContents* web_contents) {
PluginObserver::CreateForWebContents(web_contents);
SadTabHelper::CreateForWebContents(web_contents);
safe_browsing::SafeBrowsingTabObserver::CreateForWebContents(web_contents);
+ safe_browsing::SafeBrowsingNavigationObserver::MaybeCreateForWebContents(
+ web_contents);
Avi (use Gerrit) 2016/12/20 02:44:26 You only need the includes for these objects.
Jialiu Lin 2016/12/20 03:16:54 Done.
TabContentsSyncedTabDelegate::CreateForWebContents(web_contents);
TabDialogs::CreateForWebContents(web_contents);
ThumbnailTabHelper::CreateForWebContents(web_contents);

Powered by Google App Engine
This is Rietveld 408576698