Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Side by Side Diff: content/browser/find_request_manager_browsertest.cc

Issue 2578353002: Mark FindRequestManagerTest.RapidFire flaky on win (Closed)
Patch Set: proof-reading Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/strings/utf_string_conversions.h" 6 #include "base/strings/utf_string_conversions.h"
7 #include "content/browser/web_contents/web_contents_impl.h" 7 #include "content/browser/web_contents/web_contents_impl.h"
8 #include "content/public/browser/notification_types.h" 8 #include "content/public/browser/notification_types.h"
9 #include "content/public/common/content_switches.h" 9 #include "content/public/common/content_switches.h"
10 #include "content/public/test/browser_test_utils.h" 10 #include "content/public/test/browser_test_utils.h"
(...skipping 407 matching lines...) Expand 10 before | Expand all | Expand 10 after
418 Find("resul", default_options); 418 Find("resul", default_options);
419 Find("result", default_options); 419 Find("result", default_options);
420 delegate()->WaitForFinalReply(); 420 delegate()->WaitForFinalReply();
421 421
422 FindResults results = delegate()->GetFindResults(); 422 FindResults results = delegate()->GetFindResults();
423 EXPECT_EQ(last_request_id(), results.request_id); 423 EXPECT_EQ(last_request_id(), results.request_id);
424 EXPECT_EQ(19, results.number_of_matches); 424 EXPECT_EQ(19, results.number_of_matches);
425 EXPECT_EQ(1, results.active_match_ordinal); 425 EXPECT_EQ(1, results.active_match_ordinal);
426 } 426 }
427 427
428 // TODO(crbug.com/615291): This test frequently fails on Android.
429 // TODO(crbug.com/674742): This test is flaky on Win
430 #if defined(OS_ANDROID) || defined(OS_WIN)
431 #define MAYBE_RapidFire DISABLED_RapidFire
432 #else
433 #define MAYBE_RapidFire RapidFire
434 #endif
435
428 // Tests sending a large number of find requests subsequently. 436 // Tests sending a large number of find requests subsequently.
429 IN_PROC_BROWSER_TEST_P(FindRequestManagerTest, MAYBE(RapidFire)) { 437 IN_PROC_BROWSER_TEST_P(FindRequestManagerTest, MAYBE_RapidFire) {
430 LoadAndWait("/find_in_page.html"); 438 LoadAndWait("/find_in_page.html");
431 if (GetParam()) 439 if (GetParam())
432 MakeChildFrameCrossProcess(); 440 MakeChildFrameCrossProcess();
433 441
434 blink::WebFindOptions options; 442 blink::WebFindOptions options;
435 Find("result", options); 443 Find("result", options);
436 444
437 options.findNext = true; 445 options.findNext = true;
438 for (int i = 2; i <= 1000; ++i) 446 for (int i = 2; i <= 1000; ++i)
439 Find("result", options); 447 Find("result", options);
(...skipping 365 matching lines...) Expand 10 before | Expand all | Expand 10 after
805 delegate()->MarkNextReply(); 813 delegate()->MarkNextReply();
806 contents()->ActivateNearestFindResult( 814 contents()->ActivateNearestFindResult(
807 rects[order[i]].CenterPoint().x(), rects[order[i]].CenterPoint().y()); 815 rects[order[i]].CenterPoint().x(), rects[order[i]].CenterPoint().y());
808 delegate()->WaitForNextReply(); 816 delegate()->WaitForNextReply();
809 EXPECT_EQ(order[i] + 1, delegate()->GetFindResults().active_match_ordinal); 817 EXPECT_EQ(order[i] + 1, delegate()->GetFindResults().active_match_ordinal);
810 } 818 }
811 } 819 }
812 #endif // defined(OS_ANDROID) 820 #endif // defined(OS_ANDROID)
813 821
814 } // namespace content 822 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698