Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp

Issue 2578343002: Support compositing for active animations in SPv2. (Closed)
Patch Set: setNeedsPaintPropertyUpdate on PaintLayer::styleDidChange. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp b/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp
index 36827167359ab6bb0afe50fedaec2933813ac38d..ca872f5b06e350207064bb285ba10c41eae0c819 100644
--- a/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp
@@ -8,6 +8,7 @@
#include "core/layout/LayoutTestHelper.h"
#include "core/layout/LayoutView.h"
#include "platform/json/JSONValues.h"
+#include "platform/testing/RuntimeEnabledFeaturesTestHelpers.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace blink {
@@ -124,19 +125,6 @@ TEST_F(LayoutObjectTest, PaintingLayerOfOverflowClipLayerUnderColumnSpanAll) {
EXPECT_EQ(columns->layer(), overflowClipObject->paintingLayer());
}
-namespace {
-
-class ScopedSPv2 {
- public:
- ScopedSPv2() { RuntimeEnabledFeatures::setSlimmingPaintV2Enabled(true); }
- ~ScopedSPv2() { m_featuresBackup.restore(); }
-
- private:
- RuntimeEnabledFeatures::Backup m_featuresBackup;
-};
-
-} // namespace
-
TEST_F(LayoutObjectTest, MutableForPaintingClearPaintFlags) {
LayoutObject* object = document().body()->layoutObject();
object->setShouldDoFullPaintInvalidation();
@@ -158,7 +146,7 @@ TEST_F(LayoutObjectTest, MutableForPaintingClearPaintFlags) {
object->m_bitfields.setDescendantNeedsPaintPropertyUpdate(true);
EXPECT_TRUE(object->descendantNeedsPaintPropertyUpdate());
- ScopedSPv2 enableSPv2;
+ ScopedSlimmingPaintV2ForTest enableSPv2(true);
document().lifecycle().advanceTo(DocumentLifecycle::InPrePaint);
object->getMutableForPainting().clearPaintFlags();
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.h ('k') | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698