Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Side by Side Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2578343002: Support compositing for active animations in SPv2. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999 Lars Knoll <knoll@kde.org> 3 * 1999 Lars Knoll <knoll@kde.org>
4 * 1999 Antti Koivisto <koivisto@kde.org> 4 * 1999 Antti Koivisto <koivisto@kde.org>
5 * 2000 Dirk Mueller <mueller@kde.org> 5 * 2000 Dirk Mueller <mueller@kde.org>
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * Copyright (C) 2009 Google Inc. All rights reserved. 9 * Copyright (C) 2009 Google Inc. All rights reserved.
10 * 10 *
(...skipping 2855 matching lines...) Expand 10 before | Expand all | Expand 10 after
2866 frameView.m_allowsLayoutInvalidationAfterLayoutClean = false; 2866 frameView.m_allowsLayoutInvalidationAfterLayoutClean = false;
2867 }); 2867 });
2868 2868
2869 { 2869 {
2870 TRACE_EVENT1("devtools.timeline", "UpdateLayerTree", "data", 2870 TRACE_EVENT1("devtools.timeline", "UpdateLayerTree", "data",
2871 InspectorUpdateLayerTreeEvent::data(m_frame.get())); 2871 InspectorUpdateLayerTreeEvent::data(m_frame.get()));
2872 2872
2873 if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) { 2873 if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
2874 view.compositor()->updateIfNeededRecursive(); 2874 view.compositor()->updateIfNeededRecursive();
2875 } else { 2875 } else {
2876 DocumentAnimations::updateAnimations(layoutView()->document());
2877
2878 forAllNonThrottledFrameViews([](FrameView& frameView) { 2876 forAllNonThrottledFrameViews([](FrameView& frameView) {
2879 frameView.layoutView()->layer()->updateDescendantDependentFlags(); 2877 frameView.layoutView()->layer()->updateDescendantDependentFlags();
2880 frameView.layoutView()->commitPendingSelection(); 2878 frameView.layoutView()->commitPendingSelection();
2881 }); 2879 });
2882 } 2880 }
2883 2881
2884 scrollContentsIfNeededRecursive(); 2882 scrollContentsIfNeededRecursive();
2885 DCHECK(RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled() || 2883 DCHECK(RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled() ||
2886 lifecycle().state() >= DocumentLifecycle::CompositingClean); 2884 lifecycle().state() >= DocumentLifecycle::CompositingClean);
2887 2885
2888 m_frame->host()->globalRootScrollerController().didUpdateCompositing(); 2886 m_frame->host()->globalRootScrollerController().didUpdateCompositing();
2889 2887
2890 if (targetState >= DocumentLifecycle::PrePaintClean) { 2888 if (targetState >= DocumentLifecycle::PrePaintClean) {
2891 if (!RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled()) 2889 if (!RuntimeEnabledFeatures::slimmingPaintInvalidationEnabled())
2892 invalidateTreeIfNeededRecursive(); 2890 invalidateTreeIfNeededRecursive();
2893 2891
2894 if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) { 2892 if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
2895 if (view.compositor()->inCompositingMode()) 2893 if (view.compositor()->inCompositingMode())
2896 scrollingCoordinator()->updateAfterCompositingChangeIfNeeded(); 2894 scrollingCoordinator()->updateAfterCompositingChangeIfNeeded();
2897 } 2895 }
2898 2896
2899 updateCompositedSelectionIfNeeded(); 2897 updateCompositedSelectionIfNeeded();
2900 } 2898 }
2901 } 2899 }
2902 2900
2903 if (targetState >= DocumentLifecycle::PrePaintClean) { 2901 if (targetState >= DocumentLifecycle::PrePaintClean) {
2904 updatePaintProperties(); 2902 updatePaintProperties();
2905 } 2903 }
2906 2904
2905 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
wkorman 2016/12/15 23:06:00 Will remove before landing, this is manual patch o
2906 DocumentAnimations::updateAnimations(layoutView()->document());
2907
2907 if (targetState == DocumentLifecycle::PaintClean) { 2908 if (targetState == DocumentLifecycle::PaintClean) {
2908 if (!m_frame->document()->printing()) 2909 if (!m_frame->document()->printing())
2909 synchronizedPaint(); 2910 synchronizedPaint();
2910 2911
2911 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) 2912 if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
2912 pushPaintArtifactToCompositor(); 2913 pushPaintArtifactToCompositor();
2913 2914
2914 DCHECK(!view.hasPendingSelection()); 2915 DCHECK(!view.hasPendingSelection());
2915 DCHECK((m_frame->document()->printing() && 2916 DCHECK((m_frame->document()->printing() &&
2916 lifecycle().state() == DocumentLifecycle::PrePaintClean) || 2917 lifecycle().state() == DocumentLifecycle::PrePaintClean) ||
(...skipping 1757 matching lines...) Expand 10 before | Expand all | Expand 10 after
4674 DCHECK(m_frame->isMainFrame()); 4675 DCHECK(m_frame->isMainFrame());
4675 return m_initialViewportSize.width(); 4676 return m_initialViewportSize.width();
4676 } 4677 }
4677 4678
4678 int FrameView::initialViewportHeight() const { 4679 int FrameView::initialViewportHeight() const {
4679 DCHECK(m_frame->isMainFrame()); 4680 DCHECK(m_frame->isMainFrame());
4680 return m_initialViewportSize.height(); 4681 return m_initialViewportSize.height();
4681 } 4682 }
4682 4683
4683 } // namespace blink 4684 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698