third_party/WebKit/Source/modules/payments/AndroidPayMethodData.idl - Issue 2578323006: Parsing new Android Pay Payment Request API member: minGooglePlayServicesVersion

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/payments/AndroidPayMethodData.idl

Issue 2578323006: Parsing new Android Pay Payment Request API member: minGooglePlayServicesVersion (Closed)

Patch Set: making minGooglePlayServicesVersion an int32 Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « components/payments/payment_request.mojom ('k') | third_party/WebKit/Source/modules/payments/PaymentRequest.cpp » ('j') | third_party/WebKit/Source/modules/payments/PaymentRequest.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // https://developers.google.com/web/fundamentals/getting-started/primers/paymen t-request/android-pay	5 // https://developers.google.com/web/fundamentals/getting-started/primers/paymen t-request/android-pay

6 // TODO(rouslan): Stop parsing Android Pay data. http://crbug.com/620173	6 // TODO(rouslan): Stop parsing Android Pay data. http://crbug.com/620173

7	7

8 dictionary AndroidPayMethodData {	8 dictionary AndroidPayMethodData {

9 DOMString environment;	9 DOMString environment;

10 DOMString merchantName;	10 DOMString merchantName;

11 DOMString merchantId;	11 DOMString merchantId;

12 sequence<DOMString> allowedCardNetworks;	12 sequence<DOMString> allowedCardNetworks;

13 AndroidPayTokenization paymentMethodTokenizationParameters;	13 AndroidPayTokenization paymentMethodTokenizationParameters;

	14 DOMString minGooglePlayServicesVersion;
	please use gerrit instead 2016/12/19 21:47:38 You will get free parsing and error handling if yo You will get free parsing and error handling if you change DOMString to long in your API. So users will need to specify data.minGooglePlayServicesVersion=123 instead of data.minGooglePlayServicesVersion="123". Would this be better for you? https://www.w3.org/TR/WebIDL/#idl-long Walter Cacau 2016/12/19 22:16:54 Generally with numbers where we care about precisi Show quoted text On 2016/12/19 21:47:38, rouslan-intermittent-holidays wrote: > You will get free parsing and error handling if you change DOMString to long in > your API. So users will need to specify data.minGooglePlayServicesVersion=123 > instead of data.minGooglePlayServicesVersion="123". Would this be better for > you? > > https://www.w3.org/TR/WebIDL/#idl-long Generally with numbers where we care about precision we have chosen to encode them in strings rather than numbers in the JSON API and the fact that we don't have very flexible JSON parsing libraries within Google Play Services. Rather keep it as a string because the plan is to actually move the parsing it to Google Play Services.
14 };	15 };

OLD	NEW