cros: Fake implementation of DBUS biometrics client.

chromeos/dbus/biod/fake_biod_client.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROMEOS_DBUS_BIOD_FAKE_BIOD_CLIENT_H_
+#define CHROMEOS_DBUS_BIOD_FAKE_BIOD_CLIENT_H_
+
+#include "base/macros.h"
+#include "base/observer_list.h"
+#include "chromeos/chromeos_export.h"
+#include "chromeos/dbus/biod/biod_client.h"
+
+namespace dbus {
+class ObjectPath;

[Daniel Erat, 2017/04/04 02:10:57]

nit: also forward-declare Bus

[sammiequon, 2017/04/04 04:15:51]

Done.

+}  // namespace dbus
+
+namespace chromeos {
+
+// A fake implementation of BiodClient.
+class CHROMEOS_EXPORT FakeBiodClient : public BiodClient {
+ public:
+  FakeBiodClient();
+  ~FakeBiodClient() override;
+
+  // BiodClient:
+  void Init(dbus::Bus* bus) override;
+  void AddObserver(Observer* observer) override;
+  void RemoveObserver(Observer* observer) override;
+  bool HasObserver(const Observer* observer) const override;
+  void StartEnrollSession(const std::string& user_id,
+                          const std::string& label,
+                          const ObjectPathCallback& callback) override;
+  void GetRecordsForUser(const std::string& user_id,
+                         const UserRecordsCallback& callback) override;
+  void DestroyAllRecords() override;
+  void StartAuthSession(const ObjectPathCallback& callback) override;
+  void RequestType(const BiometricTypeCallback& callback) override;
+  void CancelEnrollSession(
+      const dbus::ObjectPath& enroll_session_path) override;
+  void EndAuthSession(const dbus::ObjectPath& auth_session_path) override;
+  void SetRecordLabel(const dbus::ObjectPath& record_path,
+                      const std::string& label) override;
+  void RemoveRecord(const dbus::ObjectPath& record_path) override;
+  void RequestRecordLabel(const dbus::ObjectPath& record_path,
+                          const LabelCallback& callback) override;
+
+ private:
+  void OnEnrollScanDoneReceived(biod::ScanResult type_result, bool is_complete);

[Daniel Erat, 2017/04/04 02:10:57]

what are these for? they're private and don't look like they're called anywhere.
if you're intending to call them from tests to notify observers, they should be
public instead (and placed above the BiodClient overrides). i'd probably also
rename them to e.g. NotifyAuthScanDoneReceived, NotifySessionFailedReceived,
etc. -- "On" usually implies that something is a callback.

[sammiequon, 2017/04/04 04:15:51]

These are supposed to be callbacks for a fake implementation of a fingerprint
(in part 5). But I think that seperate class can be removed, now that there is
only one fake class as apposed to before, so Ill go with your suggestion.

+  void OnAuthScanDoneReceived(biod::ScanResult type_result,
+                              const AuthScanMatches& matches);
+  void OnSessionFailedReceived();
+
+  base::ObserverList<Observer> observers_;
+
+  DISALLOW_COPY_AND_ASSIGN(FakeBiodClient);
+};
+
+}  // namespace chromeos
+
+#endif  // CHROMEOS_DBUS_BIOD_FAKE_BIOD_CLIENT_H_