a11y: Add a11y information to views::Tab and manually ignore its a11y children.

ui/views/controls/tabbed_pane/tabbed_pane.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_VIEWS_CONTROLS_TABBED_PANE_TABBED_PANE_H_
 #define UI_VIEWS_CONTROLS_TABBED_PANE_TABBED_PANE_H_
 
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "base/strings/string16.h"
 #include "ui/views/view.h"
 
 namespace views {
 
 class Label;
 class Tab;
 class TabbedPaneListener;
-class TabStrip;
+
+namespace test {
+class TabbedPaneAccessibilityMacTest;
+class TabbedPaneTest;
+}
+
+// The tab strip shown above the tab contents.
+class TabStrip : public View {

[tapted, 2017/01/12 16:33:55]

nit: move this down, after the declaration for `class Tab` (after, since the
definitions appear in the .cc after the Tab:: definitions).

[Patti Lor, 2017/01/13 05:48:38]

Done, also added forward declaration for its use in TabbedPane private members.

+ public:
+  // Internal class name.
+  static const char kViewClassName[];
+
+  TabStrip();
+  ~TabStrip() override;
+
+  // Called by TabStrip when the selected tab changes. This function is only
+  // called if |from_tab| is not null, i.e., there was a previously selected
+  // tab.
+  virtual void OnSelectedTabChanged(Tab* from_tab, Tab* to_tab);
+
+  // Overridden from View:
+  const char* GetClassName() const override;
+  void OnPaintBorder(gfx::Canvas* canvas) override;
+
+  Tab* GetSelectedTab() const;
+  Tab* GetTabAtDeltaFromSelected(int delta) const;
+  Tab* GetTabAtIndex(int index) const;
+  int GetSelectedTabIndex() const;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(TabStrip);
+};
 
 // TabbedPane is a view that shows tabs. When the user clicks on a tab, the
 // associated view is displayed.
 class VIEWS_EXPORT TabbedPane : public View {
  public:
   // Internal class name.
   static const char kViewClassName[];
 
   TabbedPane();
   ~TabbedPane() override;
@@ skipping 25 matching lines @@
   void SelectTab(Tab* tab);
 
   // Overridden from View:
   gfx::Size GetPreferredSize() const override;
   const char* GetClassName() const override;
 
  private:
   friend class FocusTraversalTest;
   friend class Tab;
   friend class TabStrip;
-  FRIEND_TEST_ALL_PREFIXES(TabbedPaneTest, AddAndSelect);
-  FRIEND_TEST_ALL_PREFIXES(TabbedPaneTest, ArrowKeyBindings);
-
-  // Get the Tab (the tabstrip view, not its content) at the valid |index|.
-  Tab* GetTabAt(int index);

[tapted, 2017/01/12 16:33:55]

@sky: this was an orphaned declaration. Friended test harnesses currently
implement it as 

   Tab* GetTabAt(int index) {
     return static_cast<Tab*>(tabbed_pane_->tab_strip_->child_at(index));
   }

but that requires the the compiler to either see the TabStrip* declaration
[current approach], or at least to know it can upcast to a views::View*. 

Alternatives/Extensions:
 - a reinterpret_cast from TabStrip* to View* could work, but is kinda ugly
(e.g. multiple inheritance could break it)
 - Provide GetTabAt() in tabbed_pane.cc [would only be used for tests]
 - tmp = GetSelectedTabIndex(); SelectTabAt(index); tab = GetSelectedTab();
SelectTabAt(tmp); return tab; [would probably work, but has side effects.]
 - move TabStrip to an internal namespace or separate file

[sky, 2017/01/12 16:39:21]

I'm ok with exposing the declaration.

[Patti Lor, 2017/01/13 05:48:38]

Thanks Trent and sky, leaving as-is then :)

+  friend class test::TabbedPaneTest;
+  friend class test::TabbedPaneAccessibilityMacTest;
 
   // Get the Tab (the tabstrip view, not its content) at the selected index.
   Tab* GetSelectedTab();
 
   // Returns the content View of the currently selected Tab.
   View* GetSelectedTabContentView();
 
   // Moves the selection by |delta| tabs, where negative delta means leftwards
   // and positive delta means rightwards. Returns whether the selection could be
   // moved by that amount; the only way this can fail is if there is only one
@@ skipping 35 matching lines @@
   bool selected() const { return contents_->visible(); }
   void SetSelected(bool selected);
 
   // Overridden from View:
   bool OnMousePressed(const ui::MouseEvent& event) override;
   void OnMouseEntered(const ui::MouseEvent& event) override;
   void OnMouseExited(const ui::MouseEvent& event) override;
   void OnGestureEvent(ui::GestureEvent* event) override;
   gfx::Size GetPreferredSize() const override;
   const char* GetClassName() const override;
+  void GetAccessibleNodeData(ui::AXNodeData* node_data) override;
+  bool HandleAccessibleAction(const ui::AXActionData& action_data) override;
   void OnFocus() override;
   void OnBlur() override;
   bool OnKeyPressed(const ui::KeyEvent& event) override;
 
  protected:
   Label* title() { return title_; }
 
   // Called whenever |tab_state_| changes.
   virtual void OnStateChanged();
 
@@ skipping 12 matching lines @@
   TabState tab_state_;
   // The content view associated with this tab.
   View* contents_;
 
   DISALLOW_COPY_AND_ASSIGN(Tab);
 };
 
 }  // namespace views
 
 #endif  // UI_VIEWS_CONTROLS_TABBED_PANE_TABBED_PANE_H_