Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(5)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: content/test/data/accessibility/aria/aria-tabpanel-expected-mac.txt
Issue
2578303003
:
a11y: Add a11y information to views::Tab and manually ignore its a11y children. (Closed)
Patch Set: Review comments.
Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/app/generated_resources.grd
chrome/browser/ui/cocoa/tabs/tab_view.mm
content/test/data/accessibility/aria/aria-tabpanel-expected-mac.txt
ui/accessibility/platform/ax_platform_node_mac.mm
ui/strings/ui_strings.grd
ui/views/BUILD.gn
ui/views/controls/tabbed_pane/tabbed_pane.h
ui/views/controls/tabbed_pane/tabbed_pane.cc
ui/views/controls/tabbed_pane/tabbed_pane_accessibility_mac_unittest.mm
ui/views/controls/tabbed_pane/tabbed_pane_unittest.cc
View unified diff
|
Download patch
« no previous file with comments
|
« chrome/browser/ui/cocoa/tabs/tab_view.mm
('k') |
ui/accessibility/platform/ax_platform_node_mac.mm »
('j') |
ui/accessibility/platform/ax_platform_node_mac.mm »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 AXWebArea AXRoleDescription='HTML content'
1 AXWebArea AXRoleDescription='HTML content'
2 ++AXGroup AXSubrole=AXTabPanel AXRoleDescription='tabpanel'
2 ++AXGroup AXSubrole=AXTabPanel AXRoleDescription='tabpanel'
3
++++AXRadioButton AXRoleDescription='tab' AXTitle='Item' AXValue='0'
3
++++AXRadioButton
AXSubrole=AXTab
AXRoleDescription='tab' AXTitle='Item' AXValue
='0'
4
++++AXRadioButton AXRoleDescription='tab' AXTitle='Prices' AXValue='0'
4
++++AXRadioButton
AXSubrole=AXTab
AXRoleDescription='tab' AXTitle='Prices' AXVal
ue='0'
OLD
NEW
« no previous file with comments
|
« chrome/browser/ui/cocoa/tabs/tab_view.mm
('k') |
ui/accessibility/platform/ax_platform_node_mac.mm »
('j') |
ui/accessibility/platform/ax_platform_node_mac.mm »
('J')
Issue 2578303003: a11y: Add a11y information to views::Tab and manually ignore its a11y children. (Closed)
Created 4 years ago by Patti Lor
Modified 3 years, 11 months ago
Reviewers: tapted, dmazzoni, sky
Base URL:
Comments: 138
This is Rietveld
408576698