a11y: Add a11y information to views::Tab and manually ignore its a11y children.

ui/views/controls/tabbed_pane/tabbed_pane_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/tabbed_pane/tabbed_pane.h"
 
 #include <memory>
 
 #include "base/macros.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/utf_string_conversions.h"
 #include "testing/gtest/include/gtest/gtest.h"
+#include "ui/accessibility/ax_action_data.h"
+#include "ui/accessibility/ax_enums.h"
 #include "ui/events/keycodes/keyboard_code_conversion.h"
+#include "ui/views/accessibility/native_view_accessibility.h"
 #include "ui/views/test/views_test_base.h"
+#include "ui/views/widget/widget.h"
 
 using base::ASCIIToUTF16;
 
 namespace views {
 
 // A view for testing that takes a fixed preferred size upon construction.
 class FixedSizeView : public View {
  public:
   explicit FixedSizeView(const gfx::Size& size)
     : size_(size) {}
 
   // Overridden from View:
   gfx::Size GetPreferredSize() const override { return size_; }
 
  private:
   const gfx::Size size_;
 
   DISALLOW_COPY_AND_ASSIGN(FixedSizeView);
 };
 
+base::string16 kTabTitle = ASCIIToUTF16("tab");

[tapted, 2017/01/06 04:25:12]

This will make a static initializer, which will get the CL reverted. Perhaps add
an anonymous namespace that includes FixedSizeView, and have a helper method
like

base::string16 DefaultTabTitle() {
  return ASCIIToUTF16("tab");
}


(or in the SelectTabWithAccessibleAction test, just add a local

  const base::string16 tab_title = ASCIIToUTF16("tab");

)

(note we only use kFooStyle naming for compile-time constants, so not all things
--e.g. strings-- declared `const` should be kFooStyle)

[Patti Lor, 2017/01/09 22:39:28]

Done.

+
 typedef ViewsTestBase TabbedPaneTest;

[tapted, 2017/01/06 04:25:12]

I think it's time to upgrade this to a proper test harness. then you can add a
helper method instead of using `std::vector<Tab*> tab_list;`

Also, we can remove all the FRIEND_TEST_ALL_PREFIXES in tabbed_pane.h and just
friend the test harness

[Patti Lor, 2017/01/09 22:39:28]

Done.

 
 // Tests TabbedPane::GetPreferredSize() and TabbedPane::Layout().
 TEST_F(TabbedPaneTest, SizeAndLayout) {
   std::unique_ptr<TabbedPane> tabbed_pane(new TabbedPane());
   View* child1 = new FixedSizeView(gfx::Size(20, 10));
   tabbed_pane->AddTab(ASCIIToUTF16("tab1"), child1);
   View* child2 = new FixedSizeView(gfx::Size(5, 5));
   tabbed_pane->AddTab(ASCIIToUTF16("tab2"), child2);
   tabbed_pane->SelectTabAt(0);
 
@@ skipping 16 matching lines @@
   EXPECT_GT(bounds.height(), 0);
   EXPECT_LT(bounds.height(), 200);
 
   // If we switch to the other tab, it should get assigned the same bounds.
   tabbed_pane->SelectTabAt(1);
   EXPECT_EQ(bounds, child2->bounds());
 }
 
 TEST_F(TabbedPaneTest, AddAndSelect) {
   std::unique_ptr<TabbedPane> tabbed_pane(new TabbedPane());
-  // Add several tabs; only the first should be a selected automatically.
+  // Add several tabs; only the first should be selected automatically.
   for (int i = 0; i < 3; ++i) {
     View* tab = new View();
-    tabbed_pane->AddTab(ASCIIToUTF16("tab"), tab);
+    tabbed_pane->AddTab(kTabTitle, tab);
     EXPECT_EQ(i + 1, tabbed_pane->GetTabCount());
     EXPECT_EQ(0, tabbed_pane->GetSelectedTabIndex());
   }
 
   // Select each tab.
   for (int i = 0; i < tabbed_pane->GetTabCount(); ++i) {
     tabbed_pane->SelectTabAt(i);
     EXPECT_EQ(i, tabbed_pane->GetSelectedTabIndex());
   }
 
   // Add a tab at index 0, it should not be selected automatically.
   View* tab0 = new View();
   tabbed_pane->AddTabAtIndex(0, ASCIIToUTF16("tab0"), tab0);
   EXPECT_NE(tab0, tabbed_pane->GetSelectedTabContentView());
   EXPECT_NE(0, tabbed_pane->GetSelectedTabIndex());
 }
 
 ui::KeyEvent MakeKeyPressedEvent(ui::KeyboardCode keyboard_code, int flags) {
   return ui::KeyEvent(ui::ET_KEY_PRESSED, keyboard_code,
                       ui::UsLayoutKeyboardCodeToDomCode(keyboard_code), flags);
 }
 
 TEST_F(TabbedPaneTest, ArrowKeyBindings) {
   std::unique_ptr<TabbedPane> tabbed_pane(new TabbedPane());
-  // Add several tabs; only the first should be a selected automatically.
+  // Add several tabs; only the first should be selected automatically.
   for (int i = 0; i < 3; ++i) {
     View* tab = new View();
-    tabbed_pane->AddTab(ASCIIToUTF16("tab"), tab);
+    tabbed_pane->AddTab(kTabTitle, tab);
     EXPECT_EQ(i + 1, tabbed_pane->GetTabCount());
   }
 
   EXPECT_EQ(0, tabbed_pane->GetSelectedTabIndex());
 
   // Right arrow should select tab 1:
   tabbed_pane->GetSelectedTab()->OnKeyPressed(
       MakeKeyPressedEvent(ui::VKEY_RIGHT, 0));
   EXPECT_EQ(1, tabbed_pane->GetSelectedTabIndex());
 
   // Left arrow should select tab 0:
   tabbed_pane->GetSelectedTab()->OnKeyPressed(
       MakeKeyPressedEvent(ui::VKEY_LEFT, 0));
   EXPECT_EQ(0, tabbed_pane->GetSelectedTabIndex());
 
   // Left arrow again should wrap to tab 2:
   tabbed_pane->GetSelectedTab()->OnKeyPressed(
       MakeKeyPressedEvent(ui::VKEY_LEFT, 0));
   EXPECT_EQ(2, tabbed_pane->GetSelectedTabIndex());
 
   // Right arrow again should wrap to tab 0:
   tabbed_pane->GetSelectedTab()->OnKeyPressed(
       MakeKeyPressedEvent(ui::VKEY_RIGHT, 0));
   EXPECT_EQ(0, tabbed_pane->GetSelectedTabIndex());
 }
 
+// Use TabbedPane::HandleAccessibleAction() to select tabs and make sure their
+// a11y information is correct.
+TEST_F(TabbedPaneTest, SelectTabWithAccessibleAction) {
+  // Testing accessibility information requires the View to have a Widget.
+  Widget* widget = new Widget;
+  Widget::InitParams params = CreateParams(Widget::InitParams::TYPE_WINDOW);
+  widget->Init(params);
+  TabbedPane* tabbed_pane = new TabbedPane();
+  widget->GetContentsView()->AddChildView(tabbed_pane);
+  widget->Show();
+
+  const int num_tabs = 2;

[tapted, 2017/01/06 04:25:12]

constexpr int kNumTabs = 2;

(constexpr helps guarantee that it is a compile-time constant, and is preferred
when that's the case now)

[Patti Lor, 2017/01/09 22:39:28]

Done, thanks I didn't know about constexpr.

+  std::vector<Tab*> tab_list;
+  for (int i = 0; i <= num_tabs; ++i) {

[tapted, 2017/01/06 04:25:12]

this ends up making 3 tabs, which I see is intentional, but it's a bit confusing
when the constant is `2`. We should make the constant 3 and update the code
below

[Patti Lor, 2017/01/09 22:39:28]

Done.

+    tabbed_pane->AddTab(kTabTitle, new View());
+    tabbed_pane->SelectTabAt(i);
+    tab_list.push_back(tabbed_pane->GetSelectedTab());
+  }
+  // Check the last tab added is selected.
+  EXPECT_EQ(num_tabs, tabbed_pane->GetSelectedTabIndex());
+
+  // Check the a11y information for each tab.
+  for (int i = 0; i <= num_tabs; ++i) {
+    ui::AXNodeData data =
+        NativeViewAccessibility::Create(tab_list[i])->GetData();
+    SCOPED_TRACE(testing::Message() << "Tab at index: " << i);
+    EXPECT_EQ(ui::AX_ROLE_TAB, data.role);
+    EXPECT_EQ(kTabTitle, data.GetString16Attribute(ui::AX_ATTR_NAME));
+    EXPECT_TRUE(data.HasStateFlag(ui::AX_STATE_SELECTABLE));
+    EXPECT_EQ(i == num_tabs, data.HasStateFlag(ui::AX_STATE_SELECTED));

[tapted, 2017/01/06 04:25:12]

e.g. i == kNumTabs - 1

[Patti Lor, 2017/01/09 22:39:28]

Done.

+  }
+
+  ui::AXActionData action;
+  action.action = ui::AX_ACTION_SET_SELECTION;
+  // Select the first tab.
+  NativeViewAccessibility::Create(tab_list[0])

[tapted, 2017/01/06 04:25:12]

I think this is leaked. It's possible you are actually the first person to write
a test for `AccessibilityPerformAction`, so it's good that we are fixing that.

In think in another CL you're changing Create to return a std::unique_ptr, so
that would resolve the leak if we want to wait for that. Alternatively, see
things done in NativeViewAccessibilityTest

A cleaner way to get at the NativeViewAccessibility to test things like
AccessiblityPerformAction might be nice too... but I don't see a clear way to do
that "nicely" in a way that is also cross-platform. Something to think about
though.

[Patti Lor, 2017/01/09 22:39:28]

Yep, I am - I think this change might land first though, so I'll use the same
approach as NativeViewAccessibilityTest to clean up and rebase the other change
when this lands.

+      ->AccessibilityPerformAction(action);
+  EXPECT_EQ(0, tabbed_pane->GetSelectedTabIndex());
+
+  // Select the second tab.
+  NativeViewAccessibility::Create(tab_list[1])
+      ->AccessibilityPerformAction(action);
+  EXPECT_EQ(1, tabbed_pane->GetSelectedTabIndex());
+  // Select the second tab again.
+  NativeViewAccessibility::Create(tab_list[1])
+      ->AccessibilityPerformAction(action);
+  EXPECT_EQ(1, tabbed_pane->GetSelectedTabIndex());
+
+  widget->Close();

[tapted, 2017/01/06 04:25:12]

nit: CloseNow()

[Patti Lor, 2017/01/09 22:39:28]

Done.

+}
+
 }  // namespace views