Chromium Code Reviews
Help | Chromium Project | Sign in
(1000)

Issue 25783002: Abstract content::BrowserThread usage out of AutofillWebDataBackendImpl. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 2 weeks ago by blundell (OOO until April 28)
Modified:
6 months, 2 weeks ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews_chromium.org, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, Albert Bodenhamer, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Abstract content::BrowserThread usage out of AutofillWebDataBackendImpl.

Instead, this class now takes in MessageLoopProxy's for the UI thread and DB
thread. All operations that were previously on BrowserThread are changed to the
corresponding operations on MessageLoopProxy.

A follow-up change will perform a similar abstraction for AutofillWebDataService.

BUG=303017
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226724

Patch Set 1 #

Total comments: 4

Patch Set 2 : Response to review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -39 lines) Lint Patch
M components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h View 1 5 chunks +21 lines, -12 lines 0 comments 0 errors Download
M components/autofill/core/browser/webdata/autofill_webdata_backend_impl.cc View 1 20 chunks +31 lines, -26 lines 0 comments 0 errors Download
M components/autofill/core/browser/webdata/autofill_webdata_service.cc View 4 chunks +8 lines, -1 line 0 comments 0 errors Download
Commit:

Messages

Total messages: 7
blundell (OOO until April 28)
Hi Ilya, This challenges follows patterns from https://chromiumcodereview.appspot.com/16174013/. Thanks, Colin
6 months, 2 weeks ago #1
Ilya Sherman
Thanks. LGTM % nits: https://codereview.chromium.org/25783002/diff/1/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h File components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h (right): https://codereview.chromium.org/25783002/diff/1/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h#newcode11 components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h:11: #include "base/message_loop/message_loop_proxy.h" nit: Seems like ...
6 months, 2 weeks ago #2
blundell (OOO until April 28)
https://codereview.chromium.org/25783002/diff/1/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h File components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h (right): https://codereview.chromium.org/25783002/diff/1/components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h#newcode11 components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h:11: #include "base/message_loop/message_loop_proxy.h" On 2013/10/02 23:27:01, Ilya Sherman wrote: > ...
6 months, 2 weeks ago #3
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/25783002/11001
6 months, 2 weeks ago #4
I haz the power (commit-bot)
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=205057
6 months, 2 weeks ago #5
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/25783002/11001
6 months, 2 weeks ago #6
I haz the power (commit-bot)
6 months, 2 weeks ago #7
Message was sent while issue was closed.
Change committed as 226724
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6