Abstract content::BrowserThread usage out of AutofillWebDataBackendImpl.

Abstract content::BrowserThread usage out of AutofillWebDataBackendImpl.

Instead, this class now takes in MessageLoopProxy's for the UI thread and DB
thread. All operations that were previously on BrowserThread are changed to the
corresponding operations on MessageLoopProxy.

A follow-up change will perform a similar abstraction for AutofillWebDataService.

BUG=303017
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=226724

[blundell, 2013-10-02 19:49:13]

Hi Ilya,

This challenges follows patterns from
https://chromiumcodereview.appspot.com/16174013/.

Thanks,

Colin

[Ilya Sherman, 2013-10-02 23:27:00]

Thanks.  LGTM % nits:

https://codereview.chromium.org/25783002/diff/1/components/autofill/core/brow...
File components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h
(right):

https://codereview.chromium.org/25783002/diff/1/components/autofill/core/brow...
components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h:11:
#include "base/message_loop/message_loop_proxy.h"
nit: Seems like this could just be forward-declared.

https://codereview.chromium.org/25783002/diff/1/components/autofill/core/brow...
components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h:50:
const scoped_refptr<base::MessageLoopProxy>& db_thread,
Hmm, should scoped_refptrs really be passed by const-reference?  The one above
is just passed by value, which seems potentially more appropriate.

[blundell, 2013-10-03 05:23:33]

https://codereview.chromium.org/25783002/diff/1/components/autofill/core/brow...
File components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h
(right):

https://codereview.chromium.org/25783002/diff/1/components/autofill/core/brow...
components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h:11:
#include "base/message_loop/message_loop_proxy.h"
On 2013/10/02 23:27:01, Ilya Sherman wrote:
> nit: Seems like this could just be forward-declared.

Done.

https://codereview.chromium.org/25783002/diff/1/components/autofill/core/brow...
components/autofill/core/browser/webdata/autofill_webdata_backend_impl.h:50:
const scoped_refptr<base::MessageLoopProxy>& db_thread,
Looking through the codebase, both get used. I'll change these for local
consistency and will consider posting the question on chromium-dev@.

On 2013/10/02 23:27:01, Ilya Sherman wrote:
> Hmm, should scoped_refptrs really be passed by const-reference?  The one above
> is just passed by value, which seems potentially more appropriate.

[commit-bot: I haz the power, 2013-10-03 05:23:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/25783002/11001

[commit-bot: I haz the power, 2013-10-03 06:59:38]

Retried try job too often on win_rel for step(s) unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2013-10-03 07:26:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/25783002/11001

[commit-bot: I haz the power, 2013-10-03 10:23:52]

Change committed as 226724