Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1405)

Issue 257823005: [Sheriff] Revert "Revert "Revert 266297 "1. Handle the case of empty embedder_extension_id...""" (Closed)

Created:
6 years, 7 months ago by Michael Achenbach
Modified:
6 years, 7 months ago
Reviewers:
rmsousa, Dan Beam
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, Michael van Ouwerkerk, extensions-reviews_chromium.org
Visibility:
Public.

Description

Revert "Revert "Revert 266297 "1. Handle the case of empty embedder_extension_id...""" This reverts commit 945604a562be79e66de3d247fe2eaaa06dc4f777 for introducing static initializers and breaking sizes. See e.g.: http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/64223 BUG=351824 TBR=dbeam@chromium.org, rmsousa@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266561

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -3235 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 6 chunks +21 lines, -18 lines 0 comments Download
M chrome/browser/extensions/api/declarative/declarative_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/webview/webview_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/menu_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/geolocation/chrome_geolocation_permission_context.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/guest_view/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/browser/guest_view/ad_view/ad_view_constants.h View 1 chunk +0 lines, -19 lines 0 comments Download
D chrome/browser/guest_view/ad_view/ad_view_constants.cc View 1 chunk +0 lines, -13 lines 0 comments Download
D chrome/browser/guest_view/ad_view/ad_view_guest.h View 1 chunk +0 lines, -49 lines 0 comments Download
D chrome/browser/guest_view/ad_view/ad_view_guest.cc View 1 chunk +0 lines, -58 lines 0 comments Download
D chrome/browser/guest_view/guest_view.h View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/browser/guest_view/guest_view_base.h View 1 chunk +0 lines, -143 lines 0 comments Download
D chrome/browser/guest_view/guest_view_base.cc View 1 chunk +0 lines, -205 lines 0 comments Download
D chrome/browser/guest_view/guest_view_constants.h View 1 chunk +0 lines, -28 lines 0 comments Download
D chrome/browser/guest_view/guest_view_constants.cc View 1 chunk +0 lines, -22 lines 0 comments Download
D chrome/browser/guest_view/web_view/context_menu_content_type_web_view.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/guest_view/web_view/context_menu_content_type_web_view.cc View 1 chunk +0 lines, -32 lines 0 comments Download
D chrome/browser/guest_view/web_view/javascript_dialog_helper.h View 1 chunk +0 lines, -53 lines 0 comments Download
D chrome/browser/guest_view/web_view/javascript_dialog_helper.cc View 1 chunk +0 lines, -104 lines 0 comments Download
D chrome/browser/guest_view/web_view/plugin_permission_helper.h View 1 chunk +0 lines, -48 lines 0 comments Download
D chrome/browser/guest_view/web_view/plugin_permission_helper.cc View 1 chunk +0 lines, -109 lines 0 comments Download
D chrome/browser/guest_view/web_view/web_view_constants.h View 1 chunk +0 lines, -89 lines 0 comments Download
D chrome/browser/guest_view/web_view/web_view_constants.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D chrome/browser/guest_view/web_view/web_view_find_helper.h View 1 chunk +0 lines, -186 lines 0 comments Download
D chrome/browser/guest_view/web_view/web_view_find_helper.cc View 1 chunk +0 lines, -279 lines 0 comments Download
D chrome/browser/guest_view/web_view/web_view_guest.h View 1 chunk +0 lines, -323 lines 0 comments Download
D chrome/browser/guest_view/web_view/web_view_guest.cc View 1 chunk +0 lines, -1023 lines 0 comments Download
D chrome/browser/guest_view/web_view/web_view_permission_types.h View 1 chunk +0 lines, -30 lines 0 comments Download
A + chrome/browser/guestview/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/guestview/adview/adview_constants.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/guestview/adview/adview_constants.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/guestview/adview/adview_guest.h View 3 chunks +12 lines, -7 lines 0 comments Download
A + chrome/browser/guestview/adview/adview_guest.cc View 4 chunks +26 lines, -9 lines 0 comments Download
A + chrome/browser/guestview/guestview.h View 8 chunks +43 lines, -36 lines 0 comments Download
A + chrome/browser/guestview/guestview.cc View 8 chunks +86 lines, -68 lines 0 comments Download
A + chrome/browser/guestview/guestview_constants.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/guestview/guestview_constants.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/guestview/webview/context_menu_content_type_webview.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/guestview/webview/context_menu_content_type_webview.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/guestview/webview/javascript_dialog_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/guestview/webview/javascript_dialog_helper.cc View 1 chunk +5 lines, -5 lines 0 comments Download
A + chrome/browser/guestview/webview/plugin_permission_helper.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/guestview/webview/plugin_permission_helper.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + chrome/browser/guestview/webview/webview_constants.h View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/guestview/webview/webview_constants.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/guestview/webview/webview_find_helper.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/guestview/webview/webview_find_helper.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/guestview/webview/webview_guest.h View 3 chunks +14 lines, -10 lines 0 comments Download
A + chrome/browser/guestview/webview/webview_guest.cc View 19 chunks +54 lines, -39 lines 0 comments Download
A + chrome/browser/guestview/webview/webview_permission_types.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/renderer_context_menu/context_menu_content_type_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/renderer_context_menu/render_view_context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +22 lines, -23 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Michael Achenbach
The CQ bit was checked by machenbach@chromium.org
6 years, 7 months ago (2014-04-28 14:22:16 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/257823005/1
6 years, 7 months ago (2014-04-28 14:22:42 UTC) #2
commit-bot: I haz the power
Change committed as 266561
6 years, 7 months ago (2014-04-28 14:24:08 UTC) #3
Dan Beam
please explain why you're reverting next time
6 years, 7 months ago (2014-04-28 18:19:55 UTC) #4
Michael Achenbach
yes sorry - I added the explanation to the CL description after committing.
6 years, 7 months ago (2014-04-28 18:25:08 UTC) #5
Dan Beam
On 2014/04/28 18:25:08, Michael Achenbach wrote: > yes sorry - I added the explanation to ...
6 years, 7 months ago (2014-04-28 18:26:35 UTC) #6
Michael Achenbach
On 2014/04/28 18:26:35, Dan Beam wrote: > On 2014/04/28 18:25:08, Michael Achenbach wrote: > > ...
6 years, 7 months ago (2014-04-28 18:30:39 UTC) #7
Dan Beam
6 years, 7 months ago (2014-04-28 18:31:10 UTC) #8
Message was sent while issue was closed.
On 2014/04/28 18:30:39, Michael Achenbach wrote:
> On 2014/04/28 18:26:35, Dan Beam wrote:
> > On 2014/04/28 18:25:08, Michael Achenbach wrote:
> > > yes sorry - I added the explanation to the CL description after
committing.
> > 
> > where?  do you have a link?
> 
> Right here in this CL... you just have to view the CL in rietveld. But I can
> repeat:
> This reverts commit 945604a562be79e66de3d247fe2eaaa06dc4f777 for introducing
> static initializers and breaking sizes. See e.g.: 
> http://build.chromium.org/p/chromium/builders/Linux%20x64/builds/64223

ah, ok, thanks

Powered by Google App Engine
This is Rietveld 408576698