Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Issue 257823004: Revert of Set kCanMaximizeKey/kCanResizeKey before adding to parent. (Closed)

Created:
6 years, 8 months ago by tapted
Modified:
6 years, 8 months ago
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org, Mr4D (OOO till 08-26)
Visibility:
Public.

Description

Revert of Set kCanMaximizeKey/kCanResizeKey before adding to parent. (https://codereview.chromium.org/251733004/) Reason for revert: NativeWidgetAuraTest.TestPropertiesWhenAddedToLayout triggering lsan errors link: http://build.chromium.org/p/chromium.memory/builders/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/builds/1042 errors like Direct leak of 24 byte(s) in 1 object(s) allocated from: .. #1 0x97042a in views::(anonymous namespace)::NativeWidgetAuraTest_TestPropertiesWhenAddedToLayout_Test::TestBody() ui/views/widget/native_widget_aura_unittest.cc:238 Original issue's description: > Set kCanMaximizeKey/kCanResizeKey before adding to parent. > > BUG=None > TEST=NativeWidgetAuraTest.TestPropertiesWhenAddedToLayout > R=ben@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266386 TBR=ben@chromium.org,oshima@chromium.org NOTREECHECKS=true NOTRY=true BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266419

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -97 lines) Patch
M ui/views/widget/native_widget_aura.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 5 chunks +24 lines, -90 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tapted
Created Revert of Set kCanMaximizeKey/kCanResizeKey before adding to parent.
6 years, 8 months ago (2014-04-28 01:16:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tapted@chromium.org/257823004/1
6 years, 8 months ago (2014-04-28 01:17:38 UTC) #2
commit-bot: I haz the power
6 years, 8 months ago (2014-04-28 01:18:40 UTC) #3
Message was sent while issue was closed.
Change committed as 266419

Powered by Google App Engine
This is Rietveld 408576698