Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(242)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 257823003: Cleanup: Remove unnecessary DCHECKs. (Closed)

Created:
6 years, 8 months ago by Marc Treib
Modified:
6 years, 7 months ago
Reviewers:
marja
CC:
chromium-reviews
Visibility:
Public.

Description

Cleanup: Remove some unnecessary DCHECKs in serialized_navigation_entry.cc. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266765

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M components/sessions/serialized_navigation_entry.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
Marc Treib
6 years, 8 months ago (2014-04-25 15:25:46 UTC) #1
marja
lgtm
6 years, 8 months ago (2014-04-25 15:39:08 UTC) #2
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 7 months ago (2014-04-28 07:25:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/257823003/1
6 years, 7 months ago (2014-04-28 07:26:52 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 08:52:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 7 months ago (2014-04-28 08:52:09 UTC) #6
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 7 months ago (2014-04-28 09:01:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/257823003/1
6 years, 7 months ago (2014-04-28 09:02:22 UTC) #8
Marc Treib
The CQ bit was unchecked by treib@chromium.org
6 years, 7 months ago (2014-04-28 14:56:01 UTC) #9
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 7 months ago (2014-04-28 14:56:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/257823003/1
6 years, 7 months ago (2014-04-28 14:56:38 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-04-28 16:39:20 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on android_dbg_triggered_tests
6 years, 7 months ago (2014-04-28 16:39:20 UTC) #13
Marc Treib
The CQ bit was checked by treib@chromium.org
6 years, 7 months ago (2014-04-29 07:27:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/257823003/1
6 years, 7 months ago (2014-04-29 07:28:58 UTC) #15
commit-bot: I haz the power
6 years, 7 months ago (2014-04-29 07:30:12 UTC) #16
Message was sent while issue was closed. 
Change committed as 266765

Powered by Google App Engine
This is Rietveld 408576698